Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't put typed classes in a separate .hx module #1100

Closed
wants to merge 1 commit into from
Closed

Don't put typed classes in a separate .hx module #1100

wants to merge 1 commit into from

Conversation

Gama11
Copy link
Member

@Gama11 Gama11 commented May 17, 2014

Consistent with FlxSignal.

gamedevsam
gamedevsam reviewed May 17, 2014
View reviewed changes
flixel/input/touch/FlxTouch.hx
@@ -5,10 +5,10 @@ import flixel.FlxBasic;
import flixel.FlxCamera;
import flixel.FlxG;
import flixel.FlxObject;
import flixel.group.FlxTypedGroup;
import flixel.group.FlxGroup.FlxTypedGroup;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, this is ugly...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How so? Importing a type within the FlxGroup.hx module, makes sense to me.

You could also import FlxGroup instead if you prefer that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import flixel.group.FlxGroup

This should be sufficient ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that FlashDevelop's "organize imports" feature removes that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a bug with FlashDevelop and should be reported.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done so a while ago. ;)

@gamedevsam
Copy link
Contributor

This is a huge change, and should go on v4.0. I think it'll lead to an overall cleaner API though, so I like it.

This would be a good opportunity to add an UPGRADE.md file that would provide instructions on how users of the dev branch can fix errors introduced by this change:

Dev Branch Upgrade Guide:

Removed typed class files (commit link):
* Rename: flixel.group.FlxTypedGroup -> flixel.group.FlxGroup.FlxTypedGroup
* Rename: (...)

Gama11 added a commit to HaxeFlixel/flixel-addons that referenced this pull request May 22, 2014
@Gama11
Update for HaxeFlixel/flixel#1100
ce5566c
Gama11 added a commit to HaxeFlixel/flixel-demos that referenced this pull request May 22, 2014
@Gama11
Update for HaxeFlixel/flixel#1100
52ee7c3
Gama11 added a commit to HaxeFlixel/flixel-ui that referenced this pull request May 22, 2014
@Gama11
Update for HaxeFlixel/flixel#1100
01e1dd4
@Gama11
Copy link
Member Author

Gama11 commented May 22, 2014

Merged manually here: 62fe691

@Gama11 Gama11 closed this May 22, 2014
LaughingLeader pushed a commit to LaughingLeader/flixel-addons that referenced this pull request Jun 28, 2014
@Gama11
Update for HaxeFlixel/flixel#1100
3319528
@Gama11 Gama11 deleted the typedClasses branch May 11, 2016 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gama11 @gamedevsam @Masadow