cmd/completion: Only suggest whitelisted and visible command for help

Fallout from containers#840

containers#1055

Author: HarryMichal

src/cmd/completion.go

@@ -3,7 +3,6 @@ package cmd
 import (
 	"fmt"
 	"os"
-	"strings"
 
 	"github.com/containers/toolbox/pkg/utils"
 	"github.com/spf13/cobra"
@@ -43,13 +42,15 @@ func completionEmpty(_ *cobra.Command, _ []string, _ string) ([]string, cobra.Sh
 }
 
 func completionCommands(cmd *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
-	commandNames := []string{}
+	// init-container is hidden but documented command that is meant to be
+	// accessed by users at least via a manual page
+	commandNames := []string{"init-container"}
 	commands := cmd.Root().Commands()
+
 	for _, command := range commands {
-		if strings.Contains(command.Name(), "complet") {
-			continue
+		if !command.Hidden {
+			commandNames = append(commandNames, command.Name())
 		}
-		commandNames = append(commandNames, command.Name())
 	}
 
 	return commandNames, cobra.ShellCompDirectiveNoFileComp