Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted to implement a comfyui node. #8

Closed
JettHu opened this issue Apr 17, 2024 · 5 comments
Closed

Attempted to implement a comfyui node. #8

JettHu opened this issue Apr 17, 2024 · 5 comments

Comments

@JettHu
Copy link
Contributor

JettHu commented Apr 17, 2024

I tried to implement a version of comfyui's T-GATE but seemed to encounter some problems. The quality of the generated image declined after the apply the node.
企业微信截图_3ce8507a-d6ee-4b75-ad19-cf5d664d192d

企业微信截图_2ff2a874-3fc5-489f-b587-404615d7b684

this is the repo: https://github.com/JettHu/ComfyUI_TGate

@WentianZhang-ML
Copy link
Collaborator

Hi, thanks for your attention to our work.

I have gone through your repo. Please do not use TGATE on "attn1" and try again.

"attn1" refers to the self-attention when only_cross_attention is set as False (default config), but TGATE is only used to cache the cross-attention output

@JettHu
Copy link
Contributor Author

JettHu commented Apr 18, 2024

Hi, thanks for your attention to our work.

I have gone through your repo. Please do not use TGATE on "attn1" and try again.

"attn1" refers to the self-attention when only_cross_attention is set as False (default config), but TGATE is only used to cache the cross-attention output

thx, i'll try it

@JettHu
Copy link
Contributor Author

JettHu commented Apr 18, 2024

It works after I add a only_cross_attention switch!
tgate_workflow_example

@WentianZhang-ML
Copy link
Collaborator

Sure, you can also set only_cross_attention as False and only use TGATE on attn2, which is closer to our pipeline.

@JettHu
Copy link
Contributor Author

JettHu commented Apr 18, 2024

I'm going to close this issue

@JettHu JettHu closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants