Preserve options when doing a cache push (#423)

carlossg · dlorenc · commit 5ed45ed2fb7d · 2018-11-06T15:44:44.000-06:00
* Preserve options when doing a cache push

Otherwise options like `insecure` are lost

* Do not override original object
diff --git a/pkg/executor/push.go b/pkg/executor/push.go
@@ -126,7 +126,7 @@ func pushLayerToCache(opts *config.KanikoOptions, cacheKey string, layer v1.Laye
 	if err != nil {
 		return errors.Wrap(err, "appending layer onto empty image")
 	}
-	return DoPush(empty, &config.KanikoOptions{
-		Destinations: []string{cache},
-	})
+	cacheOpts := *opts
+	cacheOpts.Destinations = []string{cache}
+	return DoPush(empty, &cacheOpts)
 }

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ func pushLayerToCache(opts *config.KanikoOptions, cacheKey string, layer v1.Laye`
`126`	`126`	`if err != nil {`
`127`	`127`	`return errors.Wrap(err, "appending layer onto empty image")`
`128`	`128`	`}`
`129`		`- return DoPush(empty, &config.KanikoOptions{`
`130`		`- Destinations: []string{cache},`
`131`		`- })`
	`129`	`+ cacheOpts := *opts`
	`130`	`+ cacheOpts.Destinations = []string{cache}`
	`131`	`+ return DoPush(empty, &cacheOpts)`
`132`	`132`	`}`