Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: jib.httpTimeout does not work with >= 1.5.0 #1954

Closed
chanseokoh opened this issue Sep 5, 2019 · 6 comments
Closed

Regression: jib.httpTimeout does not work with >= 1.5.0 #1954

chanseokoh opened this issue Sep 5, 2019 · 6 comments
Labels
area/jib-core area/jib-gradle-plugin area/jib-maven-plugin
Milestone
v1.6.0

Comments

@chanseokoh
Copy link
Member

This is due to a bug in Google HTTP Client. Upgrade to a newer version once it becomes available here and verify it works.
@chanseokoh chanseokoh mentioned this issue Sep 5, 2019
Closed
@TadCordle
Copy link
Contributor

Looks like 1.32.0 is out.

@chanseokoh chanseokoh added this to the v1.6.0 milestone Sep 11, 2019
@chanseokoh
Copy link
Member Author

I confirm the timeout works (although I noticed a slight problem in the Apache HTTP Client library).

I also confirm the new version fixes the underlying issue in #1914, so we don't have to pin down to an older Apache HTTP Client once we upgrade to 1.32.0.

We should upgrade it for the 1.6.0 release.

@chanseokoh
Copy link
Member Author

chanseokoh commented Sep 11, 2019 •
edited
Loading

although I noticed a slight problem in the Apache HTTP Client library

Filed HTTPCLIENT-2015. This might not be a regression.

UPDATE: the above bug resolved as "not a problem".

@chanseokoh chanseokoh removed this from the v1.6.0 milestone Sep 12, 2019
@chanseokoh
Copy link
Member Author

We should put a hold on it. We may have to revert the library upgrade that was done before 1.5.0 due to #1970.

@chanseokoh
Copy link
Member Author

jib.httpTimeout should work again in 1.6.0, as we downgrade the library to an old version.

@chanseokoh chanseokoh added this to the v1.6.0 milestone Sep 13, 2019
@chanseokoh
Copy link
Member Author

This issue is actually fixed in 1.6.0 that went live, so I'll close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/jib-core area/jib-gradle-plugin area/jib-maven-plugin
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
2 participants
@TadCordle @chanseokoh