Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framebuffer draw and drawInternal method names are misleading #4061

Closed
Syst3ms opened this issue Nov 28, 2024 · 1 comment · Fixed by #4146
Closed

Framebuffer draw and drawInternal method names are misleading #4061

Syst3ms opened this issue Nov 28, 2024 · 1 comment · Fixed by #4146

Comments

@Syst3ms
Copy link

Syst3ms commented Nov 28, 2024

The current names suggest that drawInternal is a more low-level method used within draw, however this isn't the case, and in fact, draw doesn't even call drawInternal. What they actually do is as follows:

  • draw blits the color information of the Framebuffer to the framebuffer currently bound to GL.
  • drawInternal blits the Framebuffer to the viewport, by creating a single screen-sized quad and applying the "blit" shader

I'm not sure what would be best to rename them, perhaps draw/drawToViewport or, in keeping with GL names, blit/blitToViewport? The latter even uses the "blit" shader

@apple502j
Copy link
Contributor

Though code has changed, the issue still appears to exist. Fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants