[HOLD for payment 2024-06-11] [Wave Collect][Xero] Add proper offline state handling for XeroOrganizationConfigurationPage

[lakchote]

Problem

Right now, there's no logic to handle offline state for XeroOrganizationConfigurationPage.

Solution

We need to add proper offline state handling for XeroOrganizationConfigurationPage using the <OfflineWithFeedback> component. That way we'll notify the user of the pending action and of possible errors.

Issue Owner

Current Issue Owner: @bfitzexpensify

[lakchote]

cc @SzymczakJ

[SzymczakJ]

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lakchote]

Progress still happening with draft PR here.

[lakchote]

Assigning @rushatgabhane as he'll need to be paid for the C+ review of the linked PR once this hits production and the 7 day regression period passes.

[rushatgabhane]

PR merged. Payment will be handled centrally

[bfitzexpensify]

@rushatgabhane what does 'handled centrally' mean? Will you require payment through this issue for the PR review? Sounds like no, but I want to make sure that's correct.

[rushatgabhane]

@bfitzexpensify sorry i didn't give context. For the Xero project, I'm paid a flat fee.
I'm not paid on a per issue basis.

[rushatgabhane]

So yes, this issue won't require a seperate payment. I'll be paid when the Xero project is 100% delivered

[bfitzexpensify]

Cool, thanks for clarifying!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add proper offline state handling for XeroOrganizationConfigurationPage #41983

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @SzymczakJ does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: