[HOLD for payment 2023-12-07] [Theme Switching Migration] SelectionList Batch

[grgia]

As part of the Theme Switching Project, we need to migrate the following files:

• MultipleAvatars.tsx
• SelectCircle.tsx
• BaseOptionsSelector.js
• OfflineWithFeedback.js
• Icon/index.tsx
• src/styles/optionRowStyles/index.ts
• src/styles/optionRowStyles/index.native.ts

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e5eccec63c7d507e
• Upwork Job ID: 1727266939969630208
• Last Price Increase: 2023-11-22

[melvin-bot]

Triggered auto assignment to @johncschuster (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e5eccec63c7d507e

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @alitoshmatov (Internal)

[grgia]

Part of #31677

[grgia]

We may not require C+ review for this, just a heads up @alitoshmatov

[alitoshmatov]

Got it!

[koko57]

leaving a comment to be assigned :) and I will work on this one

[koko57]

I think we can add these files to this batch:

src/components/OptionsList/optionsListPropTypes.js
src/components/OptionsSelector/optionsSelectorPropTypes.js
src/styles/optionRowStyles/index.ts
src/styles/optionRowStyles/index.native.ts

[grgia]

updated!

[koko57]

@grgia sorry, I went too far with these ones: 😅
src/components/OptionsList/optionsListPropTypes.js
src/components/OptionsSelector/optionsSelectorPropTypes.js
they won't use the hook anyway and will be removed after migration to typescript. I think we can remove them from the list.

[grgia]

@koko57 done! no worries

[koko57]

@grgia PR in draft

[koko57]

PR opened for the review #31774

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feat/31678 theme switching migration selectionlist batch #31774

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alitoshmatov] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[alitoshmatov]

There is not payment for this as I didn't review anything

[johncschuster]

Thanks for calling that out, @alitoshmatov!

[johncschuster]

@grgia, was there someone else who reviewed the PR that requires payment, or were they issued payment in a different linked issue?

[melvin-bot]

@johncschuster, @grgia, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@johncschuster, @grgia, @alitoshmatov Eep! 4 days overdue now. Issues have feelings too...

[johncschuster]

I've reviewed the PR and it looks like I don't need to issue payment here. Please reopen if I've misunderstood!