Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU-In employee WS, the billable option in manual expense is auto moving #31240

Closed
3 of 6 tasks
lanitochka17 opened this issue Nov 12, 2023 · 18 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 12, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.98-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1.In old dot admin account, set re-bill expenses to client as "default to billable"
2. Launch app as employe login
3. Tap fab-- request money
4. Enter amount and tap next
5. Select employee WS
6. Tap show more and wait for a second and note billable option auto moving

Expected Result:

In employee workspace, the Billable option in manual expense must not auto move

Actual Result:

In employee workspace, the Billable option in manual expense is auto moving

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6272816_1699731986770.billable.mp4

Bug6272816_1699731986790!screenshot_2023-11-11-09-13-42-833_com android chrome

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b1dd6ea56238a2de
  • Upwork Job ID: 1729851295336857600
  • Last Price Increase: 2023-11-29
Issue OwnerCurrent Issue Owner: @robertjchen
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 12, 2023
Copy link

melvin-bot bot commented Nov 12, 2023

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

This comment was marked as off-topic.

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 12, 2023

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@robertjchen
Copy link
Contributor

It sounds like the correct behavior here should be that the billable option should already be properly set upon initial entry to this page 🤔

@robertjchen robertjchen removed the DeployBlockerCash This issue or pull request should block deployment label Nov 13, 2023
@robertjchen
Copy link
Contributor

Doesn't seem like a DeployBlocker per se. Removing the label for now- we need to figure out if it's a backend issue or if it's a frontend behavior issue (suspecting the latter).

@robertjchen robertjchen added Daily KSv2 and removed Hourly KSv2 labels Nov 13, 2023
@sophiepintoraetz sophiepintoraetz added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 13, 2023
@sophiepintoraetz
Copy link
Contributor

Adding the Help Wanted label as they might be able to help figure out front/back end!

@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
@sophiepintoraetz
Copy link
Contributor

@robertjchen - would you maybe be able to confirm here?

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2023
Copy link

melvin-bot bot commented Nov 24, 2023

@robertjchen, @sophiepintoraetz Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Nov 24, 2023
Copy link

melvin-bot bot commented Nov 26, 2023

@robertjchen @sophiepintoraetz this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@sophiepintoraetz
Copy link
Contributor

Waiting on @robertjchen to confirm here.

@melvin-bot melvin-bot bot removed the Overdue label Nov 28, 2023
@robertjchen robertjchen added Weekly KSv2 and removed Daily KSv2 labels Nov 29, 2023
@robertjchen robertjchen added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff and removed Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Nov 29, 2023
Copy link

melvin-bot bot commented Nov 29, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b1dd6ea56238a2de

Copy link

melvin-bot bot commented Nov 29, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @akinwale (Internal)

@robertjchen
Copy link
Contributor

Marking as Internal for now for additional investigation.

@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2023
@robertjchen robertjchen added Weekly KSv2 and removed Daily KSv2 labels Dec 3, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 3, 2023
@robertjchen
Copy link
Contributor

Hoping to get to this soon

Copy link

melvin-bot bot commented Dec 3, 2023

@robertjchen @sophiepintoraetz this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 3, 2023
@robertjchen robertjchen added Weekly KSv2 and removed Daily KSv2 labels Dec 6, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 6, 2023
Copy link

melvin-bot bot commented Dec 10, 2023

@robertjchen @sophiepintoraetz this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 10, 2023
@robertjchen
Copy link
Contributor

Given that this is purely in the backend, let's re-create this as an internal issue and go from there.

@melvin-bot melvin-bot bot removed the Overdue label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

5 participants