[HOLD for payment 2023-09-04] Login - Sign in with Google logo jumps after the login page is refreshed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Refresh the page

Expected Result:

The Sign in with Google logo does not jump after the page is refreshed

Actual Result:

The Sign in with Google logo jumps after the page is refreshed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Safari
• MacOS / Desktop

Version Number: 1.3.56-18

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6174586_20230823_211027.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dangrous]

I cannot reproduce this - or maybe can't see it? I only see it on the second refresh in the video, too.

I've asked in Slack for another set of eyes, so will see and continue from there.

EDIT: I wasn't looking on Safari. I see it now.

[dangrous]

hey @marcochavezf do you think you can take a look at this, since you handled the PR that added these? It's hard to diagnose since we don't show the buttons on dev and apparently the Google one looks weird on dev anyway.

[dangrous]

By default this is from this PR - #23673 - it looks like we iframe in the Google button so I'm wondering if it's loading the styles just a fraction of a second before/after the iframe is loaded, hence the jump? Hoping to figure it out further.

[dangrous]

Getting this CPed https://expensify.slack.com/archives/C07J32337/p1692811481745669

[marcaaron]

This one seems resolved now. Gonna check it off. fwiw it looks like we needed something more like this -> #25797

[dangrous]

Gonna go ahead and close this, not a perfect solution in #25797 but close enough. I'm going to make a follow up issue to look at the styling of that button in Safari, both the fact that it's cut off on the right side as well as the weird jump the G does compared to the white button.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Hide Overflow of Google Signin Button [DEPLOY BLOCKER] #25789

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[situchan]

@dangrous am I eligible compensation for PR review?

[dangrous]

yep! let me grab a bz

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dangrous]

hey @dylanexpensify we need to pay @situchan for PR review, when you have a moment!

[dylanexpensify]

Reviewing today while in the air! Currently taxi'd, will get to once I can hop on wifi! Sorry for delay!

[dylanexpensify]

Back at it after conference - completing today! Wifi was absolutely awful on flight!

[dylanexpensify]

Upwork has been a real pain with creating a new post - trying again now

[dylanexpensify]

Sent invite to job @situchan !

[dylanexpensify]

Offer sent @situchan!

[dylanexpensify]

done!