Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Awaiting Payment][$250] Migrate SwipeableView/index.native.js to function component #16203

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 43 comments
Closed
1 task

[Awaiting Payment][$250] Migrate SwipeableView/index.native.js to function component #16203

marcaaron opened this issue Mar 20, 2023 · 43 comments
Assignees
@tjferriss @MonilBhavsar @abdulrahuman5196 @ojasjadhav2
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01acfdc7006f9d7166
  • Upwork Job ID: 1685092599321219072
    • 2023-07-29
  • Automatic offers:
    • abdulrahuman5196 | Reviewer | 25857041
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate index.native.js to function component [HOLD][$250] Migrate index.native.js to function component Apr 13, 2023
@dummy-1111
Copy link
Contributor

I'd love to work on this.

@dayana7204
Copy link
Contributor

I am ready to work on this ticket. :)

@melvin-bot
Copy link

melvin-bot bot commented Jun 27, 2023

📣 @dayana7204! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@vdem0115
Copy link

vdem0115 commented Jul 7, 2023

I would like to work on this issue.

@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@rayane-d
Copy link
Contributor

rayane-d commented Jul 9, 2023

Can I work on this?

@mejed-alkoutaini
Copy link

I'm able to work on this if needed!

@marcaaron marcaaron changed the title [HOLD][$250] Migrate index.native.js to function component [$250] Migrate index.native.js to function component Jul 29, 2023
@marcaaron marcaaron changed the title [$250] Migrate index.native.js to function component [$250] Migrate SwipeableView/index.native.js to function component Jul 29, 2023
@marcaaron marcaaron added NewFeature Something to build that is a new item. and removed Improvement Item broken or needs improvement. labels Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Triggered auto assignment to @tjferriss (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@marcaaron marcaaron added the External Added to denote the issue can be worked on by a contributor label Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01acfdc7006f9d7166

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

@ojasjadhav2
Copy link
Contributor

@abdulrahuman5196 thanks for the review, the PR will be ready within few hours.

@ojasjadhav2 ojasjadhav2 mentioned this issue Jul 31, 2023
Merged
58 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 31, 2023
@ojasjadhav2
Copy link
Contributor

@abdulrahuman5196 the PR is ready for review!

@tjferriss
Copy link
Contributor

PR is awaiting @abdulrahuman5196 review

@tjferriss
Copy link
Contributor

PR review is ongoing

@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

  • when @ojasjadhav2 got assigned: 2023-07-31 13:22:04 Z
  • when the PR got merged: 2023-08-21 21:03:50 UTC
  • days elapsed: 15

On to the next one 🚀

@ojasjadhav2
Copy link
Contributor

@tjferriss @MonilBhavsar hold for payment not added yet.

@abdulrahuman5196
Copy link
Contributor

@tjferriss
Melvin didn't auto-update this issue for payment - Change deployed to prod on 24 Aug. This should be eligible for payment on 31 Aug

@ojasjadhav2
Copy link
Contributor

@tjferriss Please proceed the payment now

@ojasjadhav2
Copy link
Contributor

@kadiealexander can you help here?

@MonilBhavsar MonilBhavsar changed the title [$250] Migrate SwipeableView/index.native.js to function component [Awaiting Payment][$250] Migrate SwipeableView/index.native.js to function component Sep 1, 2023
@MonilBhavsar MonilBhavsar added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Sep 1, 2023
@MonilBhavsar
Copy link
Contributor

@tjferriss 👋 can we please issue payment here

@ojasjadhav2
Copy link
Contributor

@tjferriss please issue the payment here

@ojasjadhav2
Copy link
Contributor

@tjferriss Please check this

@tjferriss
Copy link
Contributor

I'm sorry for the delay. I'll move this to Daily.

@abdulrahuman5196 I just processed your payment in Upworks.

@ojasjadhav2 can you please apply to the job here: https://www.upwork.com/jobs/~01f07496805b01d288

@tjferriss tjferriss added Daily KSv2 and removed Weekly KSv2 labels Sep 12, 2023
@ojasjadhav2
Copy link
Contributor

@tjferriss Thanks, applied on the job now!

@melvin-bot melvin-bot bot added the Overdue label Sep 15, 2023
@MonilBhavsar
Copy link
Contributor

Payment in progress

@melvin-bot melvin-bot bot removed the Overdue label Sep 15, 2023
@tjferriss
Copy link
Contributor

The offer has been sent. Once accepted I can process payment and we can close this out.

@ojasjadhav2
Copy link
Contributor

@tjferriss offer accepted!

@tjferriss
Copy link
Contributor

@ojasjadhav2 payment has been made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjferriss tjferriss

@MonilBhavsar MonilBhavsar

@abdulrahuman5196 abdulrahuman5196

@ojasjadhav2 ojasjadhav2

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests