Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager to honor web map layer's field visibility and order when configured in map viewer FeatureTable #990

Open
azizaparveen opened this issue Oct 29, 2024 · 19 comments
Assignees
Labels
Milestone

Comments

@azizaparveen
Copy link
Collaborator

Describe requirements

Map viewer now support persisting field visibility and field order set in FeatureTable, we would like Manager to honor these settings when they are configured in map viewer
Here is a test map that has field visibility and order set up on Corvallis HistoricSite layer in Map viewer
https://solutions.mapsdevext.arcgis.com/apps/mapviewer/index.html?webmap=dcbef592ac884dbca6c9516359760950.
Manager currently do not honor these settings.

Alternatives

No response

Other Relevant Info

No response

Impact

No response

@azizaparveen
Copy link
Collaborator Author

@sarahmcdonald7 do you think we need a config option for this?

@azizaparveen azizaparveen modified the milestones: 2024.R03, 2025.R01 Oct 29, 2024
@sarahmcdonald7
Copy link
Collaborator

@azizaparveen I think Manager already honors the configurations set up in Map Viewer. I think we should just show the existing configurations from map viewer in the app configuration. We do this with the filter tool - if layers have filters set up in map viewer already we show them in the expression builder when users go to set up new filters.

@azizaparveen
Copy link
Collaborator Author

@sarahmcdonald7 in my testing I don't see Manager is honoring these, Not sure if I missed anything, could please test this as well?
Here is a test app: https://solutions.mapsdevext.arcgis.com/apps/instant/manager/index.html?appid=a1188165b1b24090b9d69191c93466ff
Test map: https://solutions.mapsdevext.arcgis.com/apps/mapviewer/index.html?webmap=dcbef592ac884dbca6c9516359760950.
image
image

@sarahmcdonald7
Copy link
Collaborator

@azizaparveen Odd, I was testing this last week and it was working for me in my app:
2024-10-29_14-23-40
2024-10-29_14-23-27
https://holistic.mapsdevext.arcgis.com/apps/instant/manager/index.html?appid=3a19c9f52d2745599fb3c04d281ea1e6

@sarahmcdonald7
Copy link
Collaborator

@azizaparveen I talk back my last comment. Just tested again today and seeing what you are seeing now too.

@sarahmcdonald7
Copy link
Collaborator

@azizaparveen I know right now field descriptions are being displayed in the table. Lucy suggested hiding descriptions behind an "i" icon.
2024-12-04_13-59-20

@azizaparveen
Copy link
Collaborator Author

@sarahmcdonald7 liked the idea Lucy suggested

@azizaparveen
Copy link
Collaborator Author

azizaparveen commented Dec 5, 2024

@sumitzarkar, basically we need to do the following:

  • Manager to honor Web map layer's field visibility when set in the Table
  • Manager to honor Web map player's field order when set in the table
  • Manager to show/hide field description using i icon as suggested above.

@sumitzarkar
Copy link
Collaborator

@azizaparveen

Manager to honor Web map layer's field visibility when set in the Table
Manager to honor Web map player's field order when set in the table

  • Currently, the manager component shows the fields and the field order using the configuration that we configure in the instant app settings
    image

  • When any field is removed or reordered in the table using Mapviewer this information is stored in attributeTableInfo property of the layer in web map details
    image

If we update the code to show the fields according to the map configuration, then the instant app settings and the component runtime will not be in sync.

Manager to show/hide field description using i icon as suggested above.

  • It would be better if we show the info icon before the column header title as it will look more aligned in all columns
    image

  • We can add an icon in the table header. Now we are looking to show the field description on hover of the icon.

@sumitzarkar
Copy link
Collaborator

sumitzarkar commented Dec 12, 2024

@azizaparveen

As discussed on the call and according to the above comment:

Manager to honor Web map layer's field visibility when set in the Table
Manager to honor Web map player's field order when set in the table

  • The manager component will always show fields and their order based on the configuration from the instant app
  • Instant app configuration should reflect the webmaps fields and order using the attributeTableInfo.
  • So this needs changes only in the instant app configuration

Manager to show/hide field description using i icon as suggested above.

  • We can show the informationIcon using the icon property of the FieldColumnTemplate
  • We need the JS API team's input to understand how to show the field description on the hover of this icon. Or if this functionality can be easily implemented in JS API itself

@azizaparveen
Copy link
Collaborator Author

Submitted an issue to take care of the field order and visibility in the configuration side https://devtopia.esri.com/WebGIS/arcgis-portal-app-templates/issues/11257

@azizaparveen
Copy link
Collaborator Author

azizaparveen commented Dec 18, 2024

Manager to show/hide field description using i icon as suggested above.

  • We can show the informationIcon using the icon property of the FieldColumnTemplate
  • We need the JS API team's input to understand how to show the field description on the hover of this icon. Or if this functionality can be easily implemented in JS API itself

Sent an email to FeatureTable team to get more info on this.

@azizaparveen azizaparveen assigned jmhauck and unassigned sumitzarkar Jan 7, 2025
@azizaparveen
Copy link
Collaborator Author

@sumitzarkar John is going to work on this issue on the configuration side.

@azizaparveen
Copy link
Collaborator Author

@sumitzarkar heard back from JS API team on showing field description on the hover of info icon. This is not currently supported but they are going to add a new property. Here is the detail, I will check back with him again next week on the progress.

"This is not currently supported OOTB on production but I will add a new property to the column template definition to allow passing in text to be assigned to the icon. If no text is provided, we will default to showing the field alias/name on hover as it does now. I will install it this week and it will be available in the 4.32 release/jsdev branch.

Example:

const table = new FeatureTable({
// ...
tableTemplate: {
columnTemplates: [
{
type: "field",
fieldName: "NAME",
label: "School Name",
icon: "education",
iconText: "Custom text for icon",
},
{
// ... field2
}
]
}
});

@azizaparveen
Copy link
Collaborator Author

Logged a new issue for the field description enhancement. #1090

@jmhauck
Copy link
Collaborator

jmhauck commented Jan 27, 2025

@azizaparveen @sarahmcdonald7 The table in the map viewer allows us to turn on/off attachment and related records fields. The field selector that is a part of the IA configuration does not currently support the same. I should be able to collect and store the relationship and attachment info for display in our component as is I believe but feel like we will need to extend the field selector to fully support this issue. Otherwise users would need to go back to the map to turn on/off attachment and relationship fields and the field selector would not always reflect that same state they see displayed in the table in Manager.

@azizaparveen
Copy link
Collaborator Author

azizaparveen commented Jan 27, 2025

@jmhauck are you talking about these two options? it makes sense to me to extend Manager configuration to support these, do you have any idea what will be the level of effort needed for this? Also, if we used Field selector component in Manager, in that case, the component needs to be updated right?

Image

@jmhauck
Copy link
Collaborator

jmhauck commented Jan 27, 2025

@azizaparveen Yes these are the options and yes the solutions component would need to be updated also to support these at runtime as well. I'm not really sure on LOE yet...still looking at it but wanted to bring this up to you all.

@azizaparveen
Copy link
Collaborator Author

azizaparveen commented Jan 27, 2025

@azizaparveen Yes these are the options and yes the solutions component would need to be updated also to support these at runtime as well. I'm not really sure on LOE yet...still looking at it but wanted to bring this up to you all.

Thanks for looking into it @jmhauck, if this gets too big to handle in R1, we can push it to R2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants