Discard edits message not showing when I make a change in a record then without clicking update button select another record

[azizaparveen]

Describe the bug

Discard edits message not showing when I make a change in a record then without clicking update button select another record.
It is not showing the Discard edits message

Expected Behavior

It should show the discard edits message since we are getting away from the Editing state without committing the edit.

Reproduction Steps & Sample

Test app: https://solutions.mapsdevext.arcgis.com/apps/instant/manager/index.html?appid=fddd9b183ae14ffb9621b3fa51f852b8

1. Launch the test app
2. Select a record
3. Click Edit button
4. Make some changes
5. Instead of clicking on Update, select another record (key step)

Other Relevant Info

No response

[azizaparveen]

cc @sarahmcdonald7

[sarahmcdonald7]

@azizaparveen Just a heads up, I don't think this is a regression. I was able to reproduce this on production. We should show that discard edits message if the app leaves an open edit form.

[azizaparveen]

@sarahmcdonald7 you are right, it is not a regression. John is working on it.

[azizaparveen]

Pushing this next release @sarahmcdonald7 @jmhauck @skrishn

[jmhauck]

@azizaparveen you will notice an issue when you are editing a feature and change layers and choose to continue editing. The layer selection in the layer picker is not showing the correct state. I will revisit this after the migration to calcite 3 is complete.

[azizaparveen]

@azizaparveen you will notice an issue when you are editing a feature and change layers and choose to continue editing. The layer selection in the layer picker is not showing the correct state. I will revisit this after the migration to calcite 3 is complete.

@john I can't repro this issue anymore

[jmhauck]

@azizaparveen your video is showing a new issue that we should fix in a patch. If you choose to continue editing the other layer should not be loading. Rather the layer the was initially loaded should still be loaded and the editor should remain active with any temp edits you have made. We have been using a method that was recommended by dev but I believe something in the editor has changed recently. I have followed up with dev about this but after some digging I see that we could potentially call another method that would trigger the expected behavior for this new issue.

[jmhauck]

In regards to

@azizaparveen you will notice an issue when you are editing a feature and change layers and choose to continue editing. The layer selection in the layer picker is not showing the correct state. I will revisit this after the migration to calcite 3 is complete.

The problem is that the state of the layer picker shows both the layer that was initially selected and being edited as well as the other layer that was selected that caused the discard prompt to show are both shown as selected:

[azizaparveen]

Sounds good @jmhauck , is it a small change, can we do it in Patch A?

[jmhauck]

@azizaparveen yes...would like to get confirmation from dev before making the commit but we should be good for patch A I believe.

[sarahmcdonald7]

Sounds good @jmhauck , is it a small change, can we do it in Patch A?

@azizaparveen If this is going to be patched for A can you create an issue in the templates repo?

[azizaparveen]

Sounds good @jmhauck , is it a small change, can we do it in Patch A?

@azizaparveen If this is going to be patched for A can you create an issue in the templates repo?

Yes, will do it in a min.