Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

[BUG] Icon dropdown shifts layout when suggestions are shown #9717

Closed
1 task done
ChinmayMhatre opened this issue Nov 3, 2023 · 11 comments · Fixed by #9898
Closed
1 task done

[BUG] Icon dropdown shifts layout when suggestions are shown #9717

ChinmayMhatre opened this issue Nov 3, 2023 · 11 comments · Fixed by #9898
Assignees
Labels
💻 aspect: code undefined 🛠 goal: fix undefined 🔢 points: 3 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@ChinmayMhatre
Copy link
Member

ChinmayMhatre commented Nov 3, 2023

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

production

Version of BioDrop (for example "v1.2.3")

Current

Description

Edit by Sara Jaoude:

In the Management pages there is a layout shift when we start typing in the icon input in:

  • add & edit links
  • add & edit milestones

Ideally the suggestion should be floating but in this case they shift the layout like a block element.

image image

I went through the code and saw the element is coming from headless ui ComboBox. I don't know if this can be don't but wanted other's opinion

Screenshots

No response

Do you want to work on this issue?

No

If you want to work on this issue...

No response

@ChinmayMhatre ChinmayMhatre added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Nov 3, 2023
Copy link
Contributor

github-actions bot commented Nov 3, 2023

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
@SaraJaoude SaraJaoude changed the title [BUG] Icon dropdown in Milestone management, shift layout went suggestions are shown [BUG] Icon dropdown in Milestone management, shift layout when suggestions are shown Nov 4, 2023
@SaraJaoude SaraJaoude changed the title [BUG] Icon dropdown in Milestone management, shift layout when suggestions are shown [BUG] Icon dropdown shifts layout when suggestions are shown Nov 4, 2023
@SaraJaoude
Copy link
Member

Thanks for raising. I will add the discussion label so that we can see what solutions the community comes up with.

@EddieHubCommunity EddieHubCommunity unlocked this conversation Nov 4, 2023
@Kamaruddheen
Copy link
Member

We should position that suggestions dropdown/list absolutely so it floats overtop of everything and add higher z-index. That way it won't affect the layout when it appears and disappears.

Extra: May be we should add some sliding up/down animation to make it look smooth.

@Abhishek-90
Copy link
Contributor

I tried something using the developers tool to see how it would look, here is a screenshot.

Screenshot 2023-11-14 150500

@Kamaruddheen
Copy link
Member

I tried something using the developers tool to see how it would look, here is a screenshot.

Screenshot 2023-11-14 150500

Could you please provide a short video or GIF that shows the behavior when we type text?

@Abhishek-90
Copy link
Contributor

Here you go @Kamaruddheen.

Manage.Links.-.Google.Chrome.2023-11-24.17-16-18.mp4

@Kamaruddheen
Copy link
Member

Kamaruddheen commented Nov 26, 2023

Looks good @Abhishek-90. Let the maintainer's decide whether to proceed with solution.

ℹ️ Kamaruddheen has some opened assigned issues: 🔧View assigned issues

@eddiejaoude
Copy link
Member

eddiejaoude commented Dec 7, 2023

I agree lets go ahead with this solution 👍 @Abhishek-90 I have assigned it to you

ℹ️ eddiejaoude has some opened assigned issues: 🔧View assigned issues

@Abhishek-90
Copy link
Contributor

Abhishek-90 commented Dec 8, 2023

Hi, can we also add status:ready for dev label as well as the points for it.

ℹ️ Abhishek-90 has some opened assigned issues: 🔧View assigned issues

@eddiejaoude
Copy link
Member

Hi, can we also add status:ready for dev label as well as the points for it.

Oh yes, sorry, I will do that now

@eddiejaoude eddiejaoude added 💻 aspect: code undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) 🔢 points: 3 undefined and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 💬 talk: discussion undefined labels Dec 11, 2023
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code undefined 🛠 goal: fix undefined 🔢 points: 3 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants