Skip to content

Commit 8cd87c7

Browse files
authored
Merge pull request #450 from tcezard/update_release_publishing
EVA-3568 - Update publish_release_files_to_ftp.py to use the new config file
2 parents 7d0b30a + ad5b37b commit 8cd87c7

File tree

1 file changed

+17
-14
lines changed

1 file changed

+17
-14
lines changed

eva-accession-release-automation/publish_release_to_ftp/publish_release_files_to_ftp.py

+17-14
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,14 @@
2020
import os
2121
from argparse import ArgumentParser
2222

23+
from ebi_eva_common_pyutils.config import cfg
24+
2325
from publish_release_to_ftp.create_assembly_name_symlinks import create_assembly_name_symlinks
2426
from ebi_eva_common_pyutils.command_utils import run_command_with_output
2527
from ebi_eva_common_pyutils.logger import logging_config
2628
from ebi_eva_internal_pyutils.metadata_utils import get_metadata_connection_handle
2729
from ebi_eva_internal_pyutils.pg_utils import get_all_results_for_query
28-
from run_release_in_embassy.run_release_for_species import get_common_release_properties
30+
from run_release_in_embassy.run_release_for_species import load_config
2931
from run_release_in_embassy.release_metadata import release_vcf_file_categories, release_text_file_categories
3032

3133
by_assembly_folder_name = "by_assembly"
@@ -42,16 +44,16 @@
4244

4345

4446
class ReleaseProperties:
45-
def __init__(self, common_release_properties_file):
47+
def __init__(self, release_version):
4648
"""
4749
Get release properties from common release properties file
4850
"""
49-
common_release_properties = get_common_release_properties(common_release_properties_file)
50-
self.private_config_xml_file = common_release_properties["private-config-xml-file"]
51-
self.release_version = common_release_properties["release-version"]
52-
self.release_species_inventory_table = common_release_properties["release-species-inventory-table"]
53-
self.staging_release_folder = common_release_properties["release-folder"]
54-
self.public_ftp_release_base_folder = common_release_properties["public-ftp-release-base-folder"]
51+
self.private_config_xml_file = cfg.query('maven', 'settings_file')
52+
self.profile = cfg.query('maven', 'environment')
53+
self.release_version = release_version
54+
self.release_species_inventory_table = cfg["inventory_table"]
55+
self.staging_release_folder = cfg["release_output"]
56+
self.public_ftp_release_base_folder = cfg["public_ftp_release_base_folder"]
5557
self.public_ftp_current_release_folder = os.path.join(self.public_ftp_release_base_folder,
5658
f"release_{self.release_version}")
5759
self.public_ftp_previous_release_folder = os.path.join(self.public_ftp_release_base_folder,
@@ -289,14 +291,14 @@ def create_species_folder(release_properties, species_current_release_folder_nam
289291
f"rm -rf {species_current_release_folder_path} && mkdir {species_current_release_folder_path}")
290292

291293

292-
def publish_release_files_to_ftp(common_release_properties_file, taxonomy_id):
293-
release_properties = ReleaseProperties(common_release_properties_file)
294+
def publish_release_files_to_ftp(release_version, taxonomy_id):
295+
release_properties = ReleaseProperties(release_version)
294296
create_requisite_folders(release_properties)
295297
# Release README, known issues etc.,
296298
publish_release_top_level_files_to_ftp(release_properties)
297299

298300
with get_metadata_connection_handle(
299-
"production_processing", release_properties.private_config_xml_file) as metadata_connection_handle:
301+
release_properties.profile, release_properties.private_config_xml_file) as metadata_connection_handle:
300302
assemblies_to_process = get_release_assemblies_info_for_taxonomy(taxonomy_id, release_properties,
301303
metadata_connection_handle)
302304
species_has_unmapped_data = "Unmapped" in set([assembly_info["assembly_accession"] for assembly_info in
@@ -333,13 +335,14 @@ def publish_release_files_to_ftp(common_release_properties_file, taxonomy_id):
333335

334336
def main():
335337
argparse = ArgumentParser(description='Publish release files to FTP')
336-
argparse.add_argument('--common_release_properties_file', required=True, type=str,
337-
help='ex: /path/to/release/properties.yml')
338+
argparse.add_argument("--release_version", type=int, required=True)
338339
argparse.add_argument('--taxonomy_id', required=True, type=int, help='ex: 9913')
339340

340341
args = argparse.parse_args()
342+
load_config()
343+
logging_config.add_stdout_handler()
341344

342-
publish_release_files_to_ftp(args.common_release_properties_file, args.taxonomy_id)
345+
publish_release_files_to_ftp(args.release_version, args.taxonomy_id)
343346

344347

345348
if __name__ == "__main__":

0 commit comments

Comments
 (0)