Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there are several potential NULL pointer dereference vulnerabilities #20

Open
xambroz opened this issue Mar 23, 2018 · 0 comments
Open

Comments

@xambroz
Copy link

xambroz commented Mar 23, 2018

Hello,
there are several places in the code where it could potentially happen that the NULL pointer result from previous tests is attempted to be derefenced.

Code like this:

       s->data = malloc(i + 1);
       memset(s->data, 0, i + 1);

Should become like this:

       s->data = malloc(i + 1);
       if (NULL == s->data)
       {
               return -1;
       }
       memset(s->data, 0, i + 1);

Please consider to accept the pull request:
#19

Best regards
Michal Ambroz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant