Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple CompoundGenerator behaviours #76

Open
DiamondJoseph opened this issue Nov 25, 2019 · 0 comments
Open

Decouple CompoundGenerator behaviours #76

DiamondJoseph opened this issue Nov 25, 2019 · 0 comments

Comments

@DiamondJoseph
Copy link
Contributor

CompoundGenerator performs 2 functions: nesting generators and creating all the points for a scan.

With the addition of Zip and Concat generators, the nesting behaviour should be removed from the the creating points generators, as these generators must work on Generators (which a CompoundGenerator is not). These models also hint that there could be further ways of combining two generators (although I'm struggling to think of geometries other than a inside b, a alongside b, a after b)

This would allow CompoundGenerator to become another normal Generator, which can be wrapped by a Zip/Concat, and could allow a model to be populated with points without a wrapping generator, which would make the matching of Java and Python concepts of generators in GDA a little simpler.

Cons: pretty large rework
Pros: separation of concerns, allows nesting Compounded models within other 'Multimodels'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant