Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trusted_facts_to_tags argument to add Agent tags from trusted facts #658

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

albertvaka
Copy link
Contributor

What does this PR do?

Adds an argument trusted_facts_to_tags that behaves much like facts_to_tags but for trusted facts.

Note it's not possible to do the same for report tags (like with report_fact_tags), since there is no Puppet API to access trusted facts from outside Puppet code.

Motivation

Feature request.

@albertvaka albertvaka requested a review from a team as a code owner October 9, 2020 13:44
@albertvaka albertvaka force-pushed the albertvaka/add-trusted_facts_to_tags branch from 1f4ef8b to 1e89c5e Compare October 9, 2020 13:46
@albertvaka albertvaka changed the title Add trusted_facts_to_tags argument to tag by trusted facts Add trusted_facts_to_tags argument to add Agent tags by trusted facts Oct 9, 2020
@albertvaka albertvaka changed the title Add trusted_facts_to_tags argument to add Agent tags by trusted facts Add trusted_facts_to_tags argument to add Agent tags from trusted facts Oct 9, 2020
Note it's not possible to do the same for report tags, since there is
no Puppet API to access trusted facts from outside Puppet code.
@albertvaka albertvaka force-pushed the albertvaka/add-trusted_facts_to_tags branch from 1e89c5e to 8d2f9c7 Compare October 9, 2020 14:08
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants