replaces full bit decomposition by rshift in emulated/assertIsEqual #354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In emulated/assertLimbEquality, previously we had:
but the bits in the binary decomposition comes from a hint; so having the "lowest bits" always constrain to 0 and not using them later on in the circuit, is a waste; it's "we have a input wire in the circuit that must always be 0" --> we don't need it.
Instead this PR replaces this by a "clean" rshift; it is essentially the same code but discard the low bits in the binary decomposition.