From 448d585ac76b2a29a93c063b36e7a8f2c38dff53 Mon Sep 17 00:00:00 2001 From: Devanshusisodiya Date: Thu, 27 Feb 2025 09:50:55 +0530 Subject: [PATCH 1/5] fix: return status code on delete integration --- python/composio/client/collections.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/python/composio/client/collections.py b/python/composio/client/collections.py index 25a3b58494b..3eedccf8369 100644 --- a/python/composio/client/collections.py +++ b/python/composio/client/collections.py @@ -1528,8 +1528,9 @@ def create( ) return IntegrationModel(**response.json()) - def remove(self, id: str) -> None: - self.client.http.delete(url=str(self.endpoint / id)) + def remove(self, id: str) -> int: + response = self.client.http.delete(url=str(self.endpoint / id)) + return response.status_code @t.overload # type: ignore def get( From d3c1a4abcfad56fbcd49eeb6229beddb50058717 Mon Sep 17 00:00:00 2001 From: Devanshusisodiya Date: Thu, 27 Feb 2025 09:55:16 +0530 Subject: [PATCH 2/5] revert --- python/composio/client/collections.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/python/composio/client/collections.py b/python/composio/client/collections.py index 3eedccf8369..25a3b58494b 100644 --- a/python/composio/client/collections.py +++ b/python/composio/client/collections.py @@ -1528,9 +1528,8 @@ def create( ) return IntegrationModel(**response.json()) - def remove(self, id: str) -> int: - response = self.client.http.delete(url=str(self.endpoint / id)) - return response.status_code + def remove(self, id: str) -> None: + self.client.http.delete(url=str(self.endpoint / id)) @t.overload # type: ignore def get( From 7611298fb311190360d46a0e8a9caccb99a801f7 Mon Sep 17 00:00:00 2001 From: Devanshusisodiya Date: Thu, 27 Feb 2025 09:57:27 +0530 Subject: [PATCH 3/5] ik linter will fail --- python/composio/client/collections.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/composio/client/collections.py b/python/composio/client/collections.py index 25a3b58494b..b0e252d5bb1 100644 --- a/python/composio/client/collections.py +++ b/python/composio/client/collections.py @@ -1529,7 +1529,7 @@ def create( return IntegrationModel(**response.json()) def remove(self, id: str) -> None: - self.client.http.delete(url=str(self.endpoint / id)) + response = self.client.http.delete(url=str(self.endpoint / id)) @t.overload # type: ignore def get( From 14452bd89a2d3a9c89a66fa3af592b6108bb446b Mon Sep 17 00:00:00 2001 From: Devanshusisodiya Date: Thu, 27 Feb 2025 10:05:16 +0530 Subject: [PATCH 4/5] revert remove add delete --- python/composio/client/collections.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/python/composio/client/collections.py b/python/composio/client/collections.py index b0e252d5bb1..bd8636894fb 100644 --- a/python/composio/client/collections.py +++ b/python/composio/client/collections.py @@ -1529,7 +1529,11 @@ def create( return IntegrationModel(**response.json()) def remove(self, id: str) -> None: + self.client.http.delete(url=str(self.endpoint / id)) + + def delete(self, id: str) -> int: response = self.client.http.delete(url=str(self.endpoint / id)) + return response.status_code @t.overload # type: ignore def get( From 6c79e0fdb76d4dcd656e3b1d613bc1b20c559d75 Mon Sep 17 00:00:00 2001 From: Devanshusisodiya Date: Thu, 27 Feb 2025 10:12:43 +0530 Subject: [PATCH 5/5] just a space --- python/composio/client/collections.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/python/composio/client/collections.py b/python/composio/client/collections.py index bd8636894fb..b4a6dcec8b2 100644 --- a/python/composio/client/collections.py +++ b/python/composio/client/collections.py @@ -1531,9 +1531,7 @@ def create( def remove(self, id: str) -> None: self.client.http.delete(url=str(self.endpoint / id)) - def delete(self, id: str) -> int: - response = self.client.http.delete(url=str(self.endpoint / id)) - return response.status_code + @t.overload # type: ignore def get(