Basic web ui features #63
Merged
+34,168
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges for Papercut.
…o the FactBase class
…erence inconsistency problems.
…ted functionalities
|
Wow! This looks very cool! Can the WebAPI server be run from the service as well as the front-end? |
|
@Jaben Very good point in your question. |
added 2 commits
July 10, 2017 23:50
…I; Fixed issues in AssemblyScanner when a plugin has a customized reference other than pre-referenced assemblies; Renamed Papercut.WebUI projects to Papercut.Module.WebUI projects
…put startup messages instead of Console.WriteLine
|
Now the web ui is launched with both desktop mode and Windows service mode. |
|
@jijiechen This is a wonderful effort. Really excellent. Merging. |
|
@Jaben Sorry for breaking the CI. I'll take some time on the issues as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these change sets, we were trying to add a web UI for Papercut.
We added a Papercut.WebUI plugin project and the server will be booted by the "PapercutServiceReadyEvent" event. To ensure our implementation works as expected, we also added a test project, the Papercut.WebUI.Test project, which was powered by xunit.
The frontend material came from the MailHog project, it was powered by AngularJS 1.3 version. Despite the framework is now a bit out dated, we just reused it to make our work done sooner.
Additionally, we changed some small codes to add testability for the solution. Thanks to the DI framework and event based architecture, this work was done easily.
Please review and give your feedback, and merge this into trunk at your convenience.
Finally, many thanks to the great idea of Papercut, and the possibilities it gives to people.
@amymengfan @Stack-Coding Please subscribe to this thread as well.