Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark swallows errors #7484

Open
nflaig opened this issue Feb 20, 2025 · 1 comment
Open

Benchmark swallows errors #7484

nflaig opened this issue Feb 20, 2025 · 1 comment
Labels
meta-bug Issues that identify a bug and require a fix.

Comments

@nflaig
Copy link
Member

nflaig commented Feb 20, 2025

Trying to load a file that does not exist via readFileSync in beforeAll hook, there is no relevant error in the logs when benchmark fails, it just says

Error processing benchmark files. No benchmark result was produced
 ✖ Error: No benchmark result was produced
    at run (file:///home/nico/projects/ethereum/lodestar/node_modules/@chainsafe/benchmark/lib/esm/cli/run.js:49:19)
    at async Object.handler (file:///home/nico/projects/ethereum/lodestar/node_modules/@chainsafe/benchmark/lib/esm/cli/cli.js:24:9)

I found multiple cases where errors are swallowed, this is just one example

@nflaig nflaig added the meta-bug Issues that identify a bug and require a fix. label Feb 20, 2025
@nflaig
Copy link
Member Author

nflaig commented Feb 20, 2025

another example from @wemeetagain

eg

import {describe, bench} from "@chainsafe/benchmark";
import * as p from "@lodestar/params";

describe("foo", () => {
  bench("bar", () => void 0);
});

will error, while

import {describe, bench} from "@chainsafe/benchmark";

describe("foo", () => {
  bench("bar", () => void 0);
});

will not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix.
Projects
None yet
Development

No branches or pull requests

1 participant