Merge pull request #437 from michael-methner/master

lvklevankhanh · web-flow · commit 0642a21dce31 · 2023-02-02T10:36:22.000+07:00
Check for negative index in dlt_file_message
diff --git a/src/shared/dlt_common.c b/src/shared/dlt_common.c
@@ -1718,7 +1718,7 @@ DltReturnValue dlt_file_message(DltFile *file, int index, int verbose)
         return DLT_RETURN_WRONG_PARAMETER;
 
     /* check if message is in range */
-    if (index >= file->counter) {
+    if (index < 0 || index >= file->counter) {
         dlt_vlog(LOG_WARNING, "Message %d out of range!\r\n", index);
         return DLT_RETURN_WRONG_PARAMETER;
     }

Original file line number	Diff line number	Diff line change
`@@ -1718,7 +1718,7 @@ DltReturnValue dlt_file_message(DltFile *file, int index, int verbose)`
`1718`	`1718`	`return DLT_RETURN_WRONG_PARAMETER;`
`1719`	`1719`
`1720`	`1720`	`/* check if message is in range */`
`1721`		`- if (index >= file->counter) {`
	`1721`	`+ if (index < 0 \|\| index >= file->counter) {`
`1722`	`1722`	`dlt_vlog(LOG_WARNING, "Message %d out of range!\r\n", index);`
`1723`	`1723`	`return DLT_RETURN_WRONG_PARAMETER;`
`1724`	`1724`	`}`