Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart complete CPU based on CPU name #82

Closed
da-ekchajzer opened this issue May 5, 2022 · 2 comments
Closed

Smart complete CPU based on CPU name #82

da-ekchajzer opened this issue May 5, 2022 · 2 comments
Assignees
Labels
functional good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@da-ekchajzer
Copy link
Collaborator

da-ekchajzer commented May 5, 2022

Problem

CPU family are used has a proxy to get the die_size_per_core of the the CPU. CPU model will be used has a proxy to get the consumption profile of the CPU. CPU family are not trivial to get for all users. We should provide a way to smart complete CPU family and model from a CPU name.

Solution

Cloud carbon footprint provides a dataset of CPU name for each CPU family. We could add :

  • A name attribute to CPU objects
  • A model_range attribute to CPU objects
  • A model_id attribute to CPU objects
  • A step in CPU smart_complete function to translate (when available) a CPU name into a CPU family and to extract CPU model from the name.
  • We should provide a way to find the associate number of core

'Translation' shouldn't be strict since CPU name format given by a user can be a little different from our data format

Example

Name : Intel Xeon Gold 6142
Manufacturer : Intel
model_range : Xeon Gold
Family : skylake // from /intel-skylake.csv
nb_cores : TODO ?

Name : Intel Xeon W-2133
Manufacturer : Intel
model_range : Xeon W
Family : skylake // from /intel-skylake.csv
nb_cores : TODO ?

Name : Intel Core i9-9820X
model_range : Intel
Model : Core i9
Family : skylake // from /intel-skylake.csv
nb_cores : TODO ?

Name : AMD RYZEN 3 1200
Manufacturer : AMD
model_range : RYZEN 3
Family : TODO ?
nb_cores : TODO ?

Name : AMD RYZEN 3 1200
Manufacturer : AMD
model_range : RYZEN 3
Family : TODO ?
nb_cores : TODO ?

Additional context or elements

Intel

AMD

See https://doc.api.boavizta.org/Explanations/smart-complete/

@da-ekchajzer
Copy link
Collaborator Author

@da-ekchajzer
Copy link
Collaborator Author

Implemented in #113 thank you, @benjaminlebigot and @samuelrince

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functional good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants