Skip to content

Azure Firewall Needs to Support -WhatIf #27667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bewatersmsft opened this issue Apr 29, 2025 · 5 comments
Open

Azure Firewall Needs to Support -WhatIf #27667

bewatersmsft opened this issue Apr 29, 2025 · 5 comments
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Network - Firewall Network Service Attention This issue is responsible by Azure service team.

Comments

@bewatersmsft
Copy link
Member

Description

Currently does not support whatif and executes anyways

https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/design-guidelines/cmdlet-best-practices.md#shouldprocess

Issue script & Debug output

https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/design-guidelines/cmdlet-best-practices.md#shouldprocess

Environment data

https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/design-guidelines/cmdlet-best-practices.md#shouldprocess

Module versions

https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/design-guidelines/cmdlet-best-practices.md#shouldprocess

Error output

https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/design-guidelines/cmdlet-best-practices.md#shouldprocess
@bewatersmsft bewatersmsft added bug This issue requires a change to an existing behavior in the product in order to be resolved. Network Network - Firewall labels Apr 29, 2025
@JCFTW
Copy link

JCFTW commented Apr 29, 2025

I just experienced this with Set-AzFirewallPolicyRuleCollectionGroup
The docs say it's supported https://learn.microsoft.com/en-us/powershell/module/az.network/set-azfirewallpolicyrulecollectiongroup?view=azps-13.4.0

@bewatersmsft
Copy link
Member Author

bewatersmsft commented Apr 29, 2025

@JCFTW I'm from the Firewall team and checked our powershell code and I can see that we did not implement the support for -WhatIf. I added an internal item to track this status so we can approach it. This issue has been linked internally

@JCFTW
Copy link

JCFTW commented Apr 30, 2025

Thanks for confirming. A quick win would be to throw an error for now if WhatIf is called until it can be properly implemented if it would take time to implement fully. Yes I did screw over my firewall rules whilst I was testing.

@isra-fel isra-fel added the Service Attention This issue is responsible by Azure service team. label May 5, 2025
Copy link
Contributor

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @aznetsuppgithub.

Copy link
Contributor

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @gopimsft, @gimotwanMSFT, @avripintoms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Network - Firewall Network Service Attention This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

3 participants