fix: hide My Account links if not relevant #3394

dkoo · 2024-09-05T16:21:29Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

I'm not sure when this changed, but at some point in the past we used to hide "Subscriptions", "Orders", and "Payment Methods" links in the My Account dashboard if the customer didn't have any subscriptions or orders to manage. This PR restores that feature to remove those links that are irrelevant to non-paying customers.

How to test the changes in this Pull Request:

Sign up as a new reader without making any purchases and log into/verify with My Account.
Confirm that "Subscriptions", "Orders", and "Payment Methods" links are not shown ("Newsletters" is still shown if the Newsletters plugin is available, to allow the user to sign up for newsletters if desired):

Complete a donation or purchase and revisit My Account. Confirm that "Subscriptions", "Orders", and "Payment Methods" links are now shown, and that "Account Details" and "Subscriptions" links are the first two items in the menu.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

ronchambers · 2024-09-13T00:08:33Z

Hi @dkoo - I took at look at this (via Claudiu) and here is my review:

I attempted to complete all the Reader Activation steps (mailchimp, captcha, etc) in my local dev, but decided to just do my testing using define( 'IS_TEST_ENV', true ) Once that was added to my config, I refreshed a test user's my-account page and the menu matched what you shared in the first screenshot above. This makes sense due to the if ( Reader_Activation::is_enabled() ) check.

I then did different types of purchases: one time (with/without saving payment info), monthly subscription, and a download. In each case, the correct menu items showed up based on the data the code checks for (subscriptions, orders + payment methods, addresses (when fields existed), and downloads).

The menu ordering matched your screenshots too.

(Unrelated to this PR's code: I also confirmed the Newsletters link will go away if Newspack Newsletters is deactivated.)

Summary: reviewed + tested = PASS.

dkoo · 2024-09-13T18:10:58Z

Thank you, @ronchambers! Are you able to give the PR an "Approved" review?

ronchambers

Approved. (Please see comment above)

ronchambers · 2024-09-13T19:12:43Z

@dkoo - If you want me to merge, let me know.

dkoo · 2024-09-13T19:13:40Z

Thanks, @ronchambers! Merging now.

# [5.4.0-alpha.6](v5.4.0-alpha.5...v5.4.0-alpha.6) (2024-09-20) ### Bug Fixes * change the current product criteria for sync ([#3416](#3416)) ([28a84bc](28a84bc)) * **esp-sync:** sync Connected Account field ([#3414](#3414)) ([61c02bc](61c02bc)) * hide My Account links if not relevant ([#3394](#3394)) ([0d039d8](0d039d8)) * **phpcs:** specify path in custom ruleset ref ([#3384](#3384)) ([b143e74](b143e74)) * prevent PHP notice while checking my-account page ([#3435](#3435)) ([146a26f](146a26f)) * **ras-sync:** deprecate redundant Signup_Page meta field ([#3439](#3439)) ([61d6de8](61d6de8)) * **reader-registration-block:** fix initial newsletter checkbox state ([1890efe](1890efe)) * replace `newspack_image_credits_placeholder` default value ([#3433](#3433)) ([c754fc2](c754fc2)) * **sync:** method name for `membership_saved` handler ([#3399](#3399)) ([2c0bf26](2c0bf26)) * **sync:** place esp sync admin features behind a constant ([#3438](#3438)) ([20a0970](20a0970)) * **sync:** remove localized number format ([#3434](#3434)) ([2243a5d](2243a5d)) ### Features * add a new action to when a ras setting is updated ([#3357](#3357)) ([35d3492](35d3492)) * **ga4:** detect gate interaction blocks ([#3408](#3408)) ([e14913c](e14913c)) * media kit page handling ([#3358](#3358)) ([4454850](4454850)) * **ras:** sync class ([#3362](#3362)) ([88acbee](88acbee)) * **ras:** unify ESP connector strategy for data events ([#3360](#3360)) ([7080864](7080864)) * **reader-activation:** ESP-related tweaks ([#3381](#3381)) ([ac68b67](ac68b67)) * remove Woo Membersip sync fields ([#3411](#3411)) ([28052e8](28052e8)) * **sync:** add ESP sync notice to RAS wizard ([#3400](#3400)) ([f9acd56](f9acd56))

matticbot · 2024-09-20T18:22:52Z

🎉 This PR is included in version 5.4.0-alpha.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [5.5.0-alpha.1](v5.4.0...v5.5.0-alpha.1) (2024-10-03) ### Bug Fixes * change the current product criteria for sync ([#3416](#3416)) ([28a84bc](28a84bc)) * **esp-meta:** handle state of the 'Woo Team' meta ([#3352](#3352)) ([ba5ea1e](ba5ea1e)) * **esp-sync:** sync Connected Account field ([#3414](#3414)) ([61c02bc](61c02bc)) * **esp-wc-metadata:** last payment date & amount handling ([#3363](#3363)) ([d1abbfe](d1abbfe)) * **guest-author:** enqueue the guest author admin script selectively ([0bf37af](0bf37af)) * hide My Account links if not relevant ([#3394](#3394)) ([0d039d8](0d039d8)) * make email template fetching deterministic ([#3341](#3341)) ([ace91aa](ace91aa)) * **phpcs:** specify path in custom ruleset ref ([#3384](#3384)) ([b143e74](b143e74)) * prevent PHP notice while checking my-account page ([#3435](#3435)) ([146a26f](146a26f)) * **ras-sync:** deprecate redundant Signup_Page meta field ([#3439](#3439)) ([61d6de8](61d6de8)) * **reader-registration-block:** fix initial newsletter checkbox state ([1890efe](1890efe)) * replace `newspack_image_credits_placeholder` default value ([#3433](#3433)) ([c754fc2](c754fc2)) * **sync:** method name for `membership_saved` handler ([#3399](#3399)) ([2c0bf26](2c0bf26)) * **sync:** place esp sync admin features behind a constant ([#3438](#3438)) ([20a0970](20a0970)) * **sync:** remove localized number format ([#3434](#3434)) ([2243a5d](2243a5d)) * wizards - update type check conditional for `custom_logo` ([#3442](#3442)) ([125f756](125f756)) * woocommerce connection tests ([#3372](#3372)) ([5cea128](5cea128)) * **woocommerce-connection:** handle explicit UTM meta fields meta ([#3371](#3371)) ([bf9e997](bf9e997)) ### Features * add a new action to when a ras setting is updated ([#3357](#3357)) ([35d3492](35d3492)) * **esp-sync:** sync membership data regardless of subscription ([#3353](#3353)) ([9f7d1de](9f7d1de)) * **ga4:** detect gate interaction blocks ([#3408](#3408)) ([e14913c](e14913c)) * **ga:** disable tracking for editors regardless of RA status ([81323c3](81323c3)) * media kit page handling ([#3358](#3358)) ([4454850](4454850)) * **memberships:** add memberships-related body classes ([b56b9d8](b56b9d8)) * **ras:** esp sync tools ([#3359](#3359)) ([d7dd754](d7dd754)) * **ras:** helper method for ESP master list ([#3355](#3355)) ([ec56d5b](ec56d5b)) * **ras:** sync class ([#3362](#3362)) ([88acbee](88acbee)) * **ras:** unify ESP connector strategy for data events ([#3360](#3360)) ([7080864](7080864)) * **reader-activation:** ESP-related tweaks ([#3381](#3381)) ([ac68b67](ac68b67)) * remove Woo Membersip sync fields ([#3411](#3411)) ([28052e8](28052e8)) * **sync:** add ESP sync notice to RAS wizard ([#3400](#3400)) ([f9acd56](f9acd56))

matticbot · 2024-10-03T20:54:13Z

🎉 This PR is included in version 5.5.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [5.5.0](v5.4.1...v5.5.0) (2024-10-08) ### Bug Fixes * cancelled subscriptions sync ([#3466](#3466)) ([b605a7f](b605a7f)) * change the current product criteria for sync ([#3416](#3416)) ([28a84bc](28a84bc)) * **esp-meta:** handle state of the 'Woo Team' meta ([#3352](#3352)) ([ba5ea1e](ba5ea1e)) * **esp-sync:** sync Connected Account field ([#3414](#3414)) ([61c02bc](61c02bc)) * **esp-wc-metadata:** last payment date & amount handling ([#3363](#3363)) ([d1abbfe](d1abbfe)) * **guest-author:** enqueue the guest author admin script selectively ([0bf37af](0bf37af)) * hide My Account links if not relevant ([#3394](#3394)) ([0d039d8](0d039d8)) * make email template fetching deterministic ([#3341](#3341)) ([ace91aa](ace91aa)) * **phpcs:** specify path in custom ruleset ref ([#3384](#3384)) ([b143e74](b143e74)) * prevent PHP notice while checking my-account page ([#3435](#3435)) ([146a26f](146a26f)) * **ras-sync:** deprecate redundant Signup_Page meta field ([#3439](#3439)) ([61d6de8](61d6de8)) * **reader-registration-block:** fix initial newsletter checkbox state ([1890efe](1890efe)) * replace `newspack_image_credits_placeholder` default value ([#3433](#3433)) ([c754fc2](c754fc2)) * **sync:** method name for `membership_saved` handler ([#3399](#3399)) ([2c0bf26](2c0bf26)) * **sync:** place esp sync admin features behind a constant ([#3438](#3438)) ([20a0970](20a0970)) * **sync:** remove localized number format ([#3434](#3434)) ([2243a5d](2243a5d)) * wizards - update type check conditional for `custom_logo` ([#3442](#3442)) ([125f756](125f756)) * woocommerce connection tests ([#3372](#3372)) ([5cea128](5cea128)) * **woocommerce-connection:** handle explicit UTM meta fields meta ([#3371](#3371)) ([bf9e997](bf9e997)) ### Features * add a new action to when a ras setting is updated ([#3357](#3357)) ([35d3492](35d3492)) * **esp-sync:** sync membership data regardless of subscription ([#3353](#3353)) ([9f7d1de](9f7d1de)) * **ga4:** detect gate interaction blocks ([#3408](#3408)) ([e14913c](e14913c)) * **ga:** disable tracking for editors regardless of RA status ([81323c3](81323c3)) * media kit page handling ([#3358](#3358)) ([4454850](4454850)) * **memberships:** add memberships-related body classes ([b56b9d8](b56b9d8)) * **ras:** esp sync tools ([#3359](#3359)) ([d7dd754](d7dd754)) * **ras:** helper method for ESP master list ([#3355](#3355)) ([ec56d5b](ec56d5b)) * **ras:** sync class ([#3362](#3362)) ([88acbee](88acbee)) * **ras:** unify ESP connector strategy for data events ([#3360](#3360)) ([7080864](7080864)) * **reader-activation:** ESP-related tweaks ([#3381](#3381)) ([ac68b67](ac68b67)) * remove Woo Membersip sync fields ([#3411](#3411)) ([28052e8](28052e8)) * **sync:** add ESP sync notice to RAS wizard ([#3400](#3400)) ([f9acd56](f9acd56))

dkoo added 2 commits September 5, 2024 10:09

fix: hide My Account links if not relevant

Verified

This commit was signed with the committer’s verified signature.

miguelpeixe Miguel Peixe

GPG key ID: 2F41B04D42A57382

Verified
Learn about vigilant mode

38f92f6

chore: move Account Details and Subscriptions to top of menu

Verified

This commit was signed with the committer’s verified signature.

miguelpeixe Miguel Peixe

GPG key ID: 2F41B04D42A57382

Verified
Learn about vigilant mode

aa576f2

dkoo added the [Status] Needs Review label Sep 5, 2024

dkoo self-assigned this Sep 5, 2024

dkoo requested a review from a team as a code owner September 5, 2024 16:21

ronchambers approved these changes Sep 13, 2024

View reviewed changes

github-actions bot added [Status] Approved and removed [Status] Needs Review labels Sep 13, 2024

dkoo merged commit 0d039d8 into trunk Sep 13, 2024
9 checks passed

dkoo deleted the fix/hide-irrelevant-my-account-links branch September 13, 2024 19:13

matticbot added the released on @alpha label Sep 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: hide My Account links if not relevant #3394

fix: hide My Account links if not relevant #3394

dkoo commented Sep 5, 2024

ronchambers commented Sep 13, 2024 •

edited

Loading

dkoo commented Sep 13, 2024

ronchambers left a comment

ronchambers commented Sep 13, 2024

dkoo commented Sep 13, 2024

matticbot commented Sep 20, 2024

matticbot commented Oct 3, 2024

fix: hide My Account links if not relevant #3394

fix: hide My Account links if not relevant #3394

Conversation

dkoo commented Sep 5, 2024

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

ronchambers commented Sep 13, 2024 • edited Loading

dkoo commented Sep 13, 2024

ronchambers left a comment

Choose a reason for hiding this comment

ronchambers commented Sep 13, 2024

dkoo commented Sep 13, 2024

matticbot commented Sep 20, 2024

matticbot commented Oct 3, 2024

ronchambers commented Sep 13, 2024 •

edited

Loading