fix: partial text domain update for the newspack plugin #2646
+589
−8,154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurelfulford
added
the
[Status] Needs Review
github-actions
bot
added
[Status] Approved
|
Thanks @dkoo! |
matticbot
pushed a commit
that referenced
this pull request
Sep 15, 2023
# [2.7.0-alpha.1](v2.6.1...v2.7.0-alpha.1) (2023-09-15) ### Bug Fixes * partial text domain update for the newspack plugin ([#2646](#2646)) ([7d92092](7d92092)) ### Features * add ads.txt manager to plugin manager ([#2639](#2639)) ([06eccaa](06eccaa)) * **amp-deprecation:** remove AMP from supported list ([#2647](#2647)) ([ef98476](ef98476)) * disable deactivate and delete for Akismet ([#2593](#2593)) ([136752a](136752a)) * replace recommended cookie plugin ([#2223](#2223)) ([4a309be](4a309be))
|
🎉 This PR is included in version 2.7.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
laurelfulford
added a commit
that referenced
this pull request
Sep 20, 2023
6 tasks
laurelfulford
added a commit
that referenced
this pull request
Sep 20, 2023
matticbot
pushed a commit
that referenced
this pull request
Sep 25, 2023
# [2.7.0](v2.6.4...v2.7.0) (2023-09-25) ### Bug Fixes * partial text domain update for the newspack plugin ([#2646](#2646)) ([7d92092](7d92092)) ### Features * add ads.txt manager to plugin manager ([#2639](#2639)) ([06eccaa](06eccaa)) * **amp-deprecation:** remove AMP from supported list ([#2647](#2647)) ([ef98476](ef98476)) * disable deactivate and delete for Akismet ([#2593](#2593)) ([136752a](136752a)) * replace recommended cookie plugin ([#2223](#2223)) ([4a309be](4a309be))
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
The text domain in the Newspack Plugin is incorrect -- it should be
newspack-plugin, matching the plugin's slug, but it isnewspack. Because of this, translations don't work.This flew under the radar for a long time because the plugin just contained backend strings, but now that it has front-end facing text -- like RAS -- it's a lot more noticeable.
This PR fixes a handful of publisher-specific strings, to help with a launch and make this PR more reasonable to test. The plan is to handle the rest of the strings in small batches so we don't end up with overwhelming test scenarios.
See 1200550061930446-as-1205509524123559
How to test the changes in this Pull Request:
newspacktonewspack-pluginin the translation strings, and greatly reducing the POT file (only strings with the updated text-domain should show up there).fake-german-translation.zip
Other information: