Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ads): handle gam connection error #1573

Merged
merged 1 commit into from
Mar 24, 2022
Merged

fix(ads): handle gam connection error #1573

merged 1 commit into from
Mar 24, 2022
+14 −10

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Handles GAM error in case the connection status method returns WP_Error.

How to test the changes in this Pull Request:

  1. Check out refactor: use namespaces newspack-ads#348 to make sure the different method names causes an error
  2. While on master visit the Ads wizard and confirm the unhandled error
  3. Check out this branch and confirm the error message is appropriate (since the method names changed, it doesn't identify that the plugin is installed and active)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Sorry, something went wrong.

@miguelpeixe
fix: handle gam connection error

Verified

This commit was signed with the committer’s verified signature.
miguelpeixe Miguel Peixe
GPG key ID: 2F41B04D42A57382
Verified
Learn about vigilant mode
6d69410
@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 24, 2022
@miguelpeixe miguelpeixe requested a review from a team as a code owner March 24, 2022 15:07
@miguelpeixe miguelpeixe self-assigned this Mar 24, 2022
@miguelpeixe miguelpeixe mentioned this pull request Mar 24, 2022
Merged
6 tasks
dkoo
dkoo approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@miguelpeixe miguelpeixe merged commit 574eeb3 into master Mar 24, 2022
@miguelpeixe miguelpeixe deleted the fix/ads-unhandled-gam-error branch March 24, 2022 17:33
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 24, 2022
matticbot pushed a commit that referenced this pull request Mar 31, 2022
@semantic-release-bot
chore(release): 1.80.0-alpha.1 [skip ci]

Verified

This commit was signed with the committer’s verified signature.
miguelpeixe Miguel Peixe
GPG key ID: 2F41B04D42A57382
Verified
Learn about vigilant mode
1ddf1a8 
# [1.80.0-alpha.1](v1.79.1...v1.80.0-alpha.1) (2022-03-31)

### Bug Fixes

* handle gam connection error ([#1573](#1573)) ([574eeb3](574eeb3))

### Features

* **ads:** Add-Ons and Ad Refresh Control integration ([#1564](#1564)) ([2964da6](2964da6))
* **ads:** integrate Broadstreet into the providers wizard ([#1465](#1465)) ([93edf0f](93edf0f))
* allow segmentation by user login status ([#1563](#1563)) ([4fd7ee9](4fd7ee9))
* **donations:** remove sidebar for default donations page ([bf10c27](bf10c27))
* **popups:** add category/tag exclusion fields to campaigns wizard UI ([#1553](#1553)) ([6b80fb8](6b80fb8))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.80.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Apr 5, 2022
@semantic-release-bot
chore(release): 1.80.0 [skip ci]

Verified

This commit was signed with the committer’s verified signature.
miguelpeixe Miguel Peixe
GPG key ID: 2F41B04D42A57382
Verified
Learn about vigilant mode
03767fb 
# [1.80.0](v1.79.1...v1.80.0) (2022-04-05)

### Bug Fixes

* **ads:** add-ons download methods ([#1585](#1585)) ([e93dbcb](e93dbcb))
* **ads:** clearing ad refresh control input ([#1587](#1587)) ([8e6723f](8e6723f))
* handle gam connection error ([#1573](#1573)) ([574eeb3](574eeb3))

### Features

* **ads:** Add-Ons and Ad Refresh Control integration ([#1564](#1564)) ([2964da6](2964da6))
* **ads:** integrate Broadstreet into the providers wizard ([#1465](#1465)) ([93edf0f](93edf0f))
* allow segmentation by user login status ([#1563](#1563)) ([4fd7ee9](4fd7ee9))
* **donations:** remove sidebar for default donations page ([bf10c27](bf10c27))
* **popups:** add category/tag exclusion fields to campaigns wizard UI ([#1553](#1553)) ([6b80fb8](6b80fb8))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.80.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dkoo dkoo mentioned this pull request Feb 3, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo

Assignees

@miguelpeixe miguelpeixe

Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miguelpeixe @matticbot @dkoo