Add a "completion" screen to the onboarding #1377
Merged
+337
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasguillot
added
the
[Status] Needs Review
dkoo
requested changes
Jan 12, 2022
There was a problem hiding this comment.
A couple of non-blocking code style suggestions, and one blocking bug that prevented me from actually completing setup.
We should also update this branch with the latest master before proceeding, as I think a bunch of things have changed since the last commits to this branch.
thomasguillot
added
[Status] Needs changes or feedback
Co-authored-by: Derrick Koo <[email protected]>
Co-authored-by: Derrick Koo <[email protected]>
Co-authored-by: Derrick Koo <[email protected]>
Co-authored-by: Derrick Koo <[email protected]>
dkoo
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
@thomasguillot I updated the branch with master and fixed merge conflicts—could you do one more round of functional testing on your end to make sure the merge went okay, then if it looks 👍 to you I think this is good to go.
github-actions
bot
added
the
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Jan 24, 2022
# [1.72.0-alpha.1](v1.71.0...v1.72.0-alpha.1) (2022-01-24) ### Bug Fixes * **ads:** ad unit error handling ([#1424](#1424)) ([a1ef5f6](a1ef5f6)) * campaigns, categories autocomplete UI ([89a26b2](89a26b2)), closes [#1126](#1126) * color picker ([#1438](#1438)) ([beea9a3](beea9a3)) * **engagement-wizard:** strip HTML from setting labels ([a181374](a181374)) * modal header ([#1439](#1439)) ([91c90fe](91c90fe)) * restore accidentally-deleted rest route ([#1443](#1443)) ([472c8ff](472c8ff)) * timeouts due to use of get_post when checking whether to allow deletion ([#1442](#1442)) ([4c3c932](4c3c932)) ### Features * add a completion screen to the onboarding ([#1377](#1377)) ([8e3ca01](8e3ca01)) * allow oauth proxy overrides ([#1389](#1389)) ([603e96d](603e96d)) * **amp:** enable disallowing explicitly kept scripts, for debugging ([302abcc](302abcc)) * remove setting footer copyright to site tagline by default ([7cba0b6](7cba0b6)), closes [#1148](#1148) * update plugin list ([#1451](#1451)) ([e3e6a68](e3e6a68))
|
🎉 This PR is included in version 1.72.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jan 25, 2022
# [1.72.0](v1.71.0...v1.72.0) (2022-01-25) ### Bug Fixes * **ads:** ad unit error handling ([#1424](#1424)) ([a1ef5f6](a1ef5f6)) * campaigns, categories autocomplete UI ([89a26b2](89a26b2)), closes [#1126](#1126) * color picker ([#1438](#1438)) ([beea9a3](beea9a3)) * **engagement-wizard:** strip HTML from setting labels ([a181374](a181374)) * modal header ([#1439](#1439)) ([91c90fe](91c90fe)) * restore accidentally-deleted rest route ([#1443](#1443)) ([472c8ff](472c8ff)) * timeouts due to use of get_post when checking whether to allow deletion ([#1442](#1442)) ([4c3c932](4c3c932)) ### Features * add a completion screen to the onboarding ([#1377](#1377)) ([8e3ca01](8e3ca01)) * allow oauth proxy overrides ([#1389](#1389)) ([603e96d](603e96d)) * **amp:** enable disallowing explicitly kept scripts, for debugging ([302abcc](302abcc)) * remove setting footer copyright to site tagline by default ([7cba0b6](7cba0b6)), closes [#1148](#1148) * update plugin list ([#1451](#1451)) ([e3e6a68](e3e6a68))
|
🎉 This PR is included in version 1.72.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Feb 9, 2022
# [1.72.0-hotfix.1](v1.71.0...v1.72.0-hotfix.1) (2022-02-09) ### Bug Fixes * **ads:** ad unit error handling ([#1424](#1424)) ([a1ef5f6](a1ef5f6)) * campaigns, categories autocomplete UI ([89a26b2](89a26b2)), closes [#1126](#1126) * color picker ([#1438](#1438)) ([beea9a3](beea9a3)) * **donations:** filter saved settings ([f09a19d](f09a19d)), closes [#1392](#1392) * **engagement-wizard:** strip HTML from setting labels ([a181374](a181374)) * lookup user by queried slug, not by login ([93c87ae](93c87ae)) * modal header ([#1439](#1439)) ([91c90fe](91c90fe)) * restore accidentally-deleted rest route ([#1443](#1443)) ([472c8ff](472c8ff)) * **setup-wizard:** donation data ([#1481](#1481)) ([14618d1](14618d1)) * **stripe:** prevent webhook processing if platform is not Stripe ([3a8cfa7](3a8cfa7)) * timeouts due to use of get_post when checking whether to allow deletion ([#1442](#1442)) ([4c3c932](4c3c932)) * tooltip position in header and remove duplicated css ([#1467](#1467)) ([a869a8e](a869a8e)) ### Features * add a completion screen to the onboarding ([#1377](#1377)) ([8e3ca01](8e3ca01)) * allow oauth proxy overrides ([#1389](#1389)) ([603e96d](603e96d)) * **amp:** enable disallowing explicitly kept scripts, for debugging ([302abcc](302abcc)) * **block-editor:** utility to relink the editor close button to a wizard screen ([#1482](#1482)) ([870f630](870f630)), closes [#1205](#1205) * **connections-fivetran:** add TOS acceptance ([#1423](#1423)) ([27334d9](27334d9)) * display all ESPs during the onboarding ([#1449](#1449)) ([40cb86f](40cb86f)) * enable AMP Plus for Jetpack Instant Search ([#1486](#1486)) ([e62c5ba](e62c5ba)) * remove integrations from onboarding and add them to connections wizard ([#1453](#1453)) ([053675b](053675b)) * remove setting footer copyright to site tagline by default ([7cba0b6](7cba0b6)), closes [#1148](#1148) * **salesforce:** check duplicate site status and disable syncs if clone ([#1425](#1425)) ([2197c93](2197c93)) * settings section hooks ([#1378](#1378)) ([0a26533](0a26533)) * support multiple control for plugin settings ([#1475](#1475)) ([e00064c](e00064c)) * update plugin list ([#1451](#1451)) ([e3e6a68](e3e6a68)) * update wizard overall design and reinstate sub-header text ([#1457](#1457)) ([29271ab](29271ab)) * use PluginSettings components for Campaigns wizard ([#1450](#1450)) ([fe8e8aa](fe8e8aa))
|
🎉 This PR is included in version 1.72.0-hotfix.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR updates a bunch of components and most importantly, add a completion screen at the end of the onboarding. This allows users to choose what they want to do once they are done instead of being redirected to the dashboard and not knowing what to do.
I've also reorganised the welcome screen a bit so both screen kind of match
How to test the changes in this Pull Request:
Other information: