Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/stripe fees setting #1376

Merged
merged 4 commits into from
Jan 4, 2022
Merged

Feat/stripe fees setting #1376

merged 4 commits into from
Jan 4, 2022

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Adds UI to customise parameters for Stripe fees.

How to test the changes in this Pull Request:

  1. Set newspack-blocks to feat/handle-zero-fees branch (feat(donate-stripe): hide fee checkbox if fees are zero newspack-blocks#985)
  2. Verify the agree-to-pay-fees checkbox input is rendered on the frontend (see feat(donate): agree to pay fees feature newspack-blocks#928)
  3. Visit the Reader Revenue wizard, ensure platform is set to Stripe
  4. Observe a new "Fee" section in "Stripe Settings" tab
  5. Set both parameters to 0, observe that the input is not rendered
  6. Set parameters to values different than the defaults (2.9 multiplier, 0.3 static portion), observe the fee amount in the input test is updated accordingly

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
miguelpeixe Miguel Peixe

Verified

This commit was signed with the committer’s verified signature.
miguelpeixe Miguel Peixe
@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Dec 17, 2021
@adekbadek adekbadek requested a review from a team December 17, 2021 11:11

Verified

This commit was signed with the committer’s verified signature.
miguelpeixe Miguel Peixe

Verified

This commit was signed with the committer’s verified signature.
miguelpeixe Miguel Peixe
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 3, 2022
@adekbadek adekbadek merged commit e1f97fc into master Jan 4, 2022
@adekbadek adekbadek deleted the feat/stripe-fees-setting branch January 4, 2022 08:58
matticbot pushed a commit that referenced this pull request Jan 6, 2022

Verified

This commit was signed with the committer’s verified signature.
miguelpeixe Miguel Peixe
# [1.71.0-alpha.1](v1.70.0...v1.71.0-alpha.1) (2022-01-06)

### Bug Fixes

* change how we check post validity when preventing page deletion ([#1407](#1407)) ([1d86ac6](1d86ac6))
* setup wizard fixes ([#1316](#1316)) ([03de101](03de101))

### Features

* **reader-revenue/stripe:** allow setting custom fee parameters ([#1376](#1376)) ([e1f97fc](e1f97fc))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.71.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jan 19, 2022

Verified

This commit was signed with the committer’s verified signature.
miguelpeixe Miguel Peixe
# [1.71.0](v1.70.0...v1.71.0) (2022-01-19)

### Bug Fixes

* change how we check post validity when preventing page deletion ([#1407](#1407)) ([1d86ac6](1d86ac6))
* setup wizard fixes ([#1316](#1316)) ([03de101](03de101))

### Features

* **reader-revenue/stripe:** allow setting custom fee parameters ([#1376](#1376)) ([e1f97fc](e1f97fc))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants