Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Useless break statement #2804

Closed
QiAnXinCodeSafe opened this issue Apr 17, 2019 · 2 comments · Fixed by #2838
Closed

Useless break statement #2804

QiAnXinCodeSafe opened this issue Apr 17, 2019 · 2 comments · Fixed by #2838
Assignees
@rudyfly

Comments

@QiAnXinCodeSafe
Copy link

Ⅰ. Issue Description

break does nothing here:
https://github.com/alibaba/pouch/blob/9f56fefa28b2237b482540f0e217135ad14a276d/storage/quota/quota.go#L289-L293

Maybe you mean breaking the loop, so you need to add a label to the break statement.
@HusterWan
Copy link
Contributor

@360CodeSafe thanks for what you have found, we should fix it @rudyfly

@rudyfly rudyfly self-assigned this Apr 17, 2019
@allencloud
Copy link
Collaborator

Any update？ Or could you help to submit a PR to fix this？ @360CodeSafe

@weekly-digest weekly-digest bot mentioned this issue Apr 28, 2019
Closed
@rudyfly rudyfly mentioned this issue May 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rudyfly rudyfly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove useless break statement rudyfly/pouch
4 participants
@rudyfly @allencloud @HusterWan @QiAnXinCodeSafe