Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[help wanted] add unit-test for ValidateCPUPeriod #1637

Closed
zhuangqh opened this issue Jul 5, 2018 · 2 comments · Fixed by #1690
Closed

[help wanted] add unit-test for ValidateCPUPeriod #1637

zhuangqh opened this issue Jul 5, 2018 · 2 comments · Fixed by #1690
Labels
areas/test good first issue

Comments

@zhuangqh
Copy link
Contributor

zhuangqh commented Jul 5, 2018

Ⅰ. Issue Description

Add unit-test for ValidateCPUPeriod method which locate on apis/opts/cpu.go.

You can take env_test.go for reference.

Ⅱ. Describe what happened

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

please "Baiji" developer refer to this issue in your PR for the convenience for us to count your score.

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@zhuangqh
Copy link
Contributor Author

zhuangqh commented Jul 6, 2018

Why is there no areas/test label? I think the description of this issue is similar to #1638
please cc @ZouRui89

@ZouRui89
Copy link
Contributor

ZouRui89 commented Jul 6, 2018 •
edited
Loading

Checked the logics of add-labels-to-issue part in cute robot...
This situation should not have happened. I think something might have been stuck in this label event. 😢

@mengjiahao mengjiahao mentioned this issue Jul 9, 2018
Closed
@youmengna youmengna mentioned this issue Jul 9, 2018
Closed
@mengjiahao mengjiahao mentioned this issue Jul 9, 2018
Closed
@hliang95 hliang95 mentioned this issue Jul 10, 2018
Closed
@faremax faremax mentioned this issue Jul 10, 2018
Closed
@johanzhu johanzhu mentioned this issue Jul 10, 2018
Merged
@jiaqilou jiaqilou mentioned this issue Jul 10, 2018
Closed
@wangyifei24 wangyifei24 mentioned this issue Jul 10, 2018
Closed
@deffisoan deffisoan mentioned this issue Jul 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
areas/test good first issue
Projects
None yet
Milestone
No milestone
3 participants
@frank-zsy @zhuangqh @ZouRui89