WIP - Resolves #73 - Implement first order differences of prediction trajectories #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmlong
changed the title
levmckinney
requested changes
Apr 23, 2023
|
|
||
| # for each input token: | ||
| # for each layer (starting at 2nd layer): | ||
| # get top k tokens for that layer |
There was a problem hiding this comment.
This should be vectorized. We don't want to be looping over the token index this will be 40k+ tokens per layer that is going to be slow. Instead, we should use an element wise subtraction. If layer[i, :] and layer[i+1, :] are NDArrays then we should just do layer[i+1, :] - layer[i, :].
In addition, we should not be thinking about the top k tokens at this point since in the end the tokens that have changed the most may not be among top k tokens in either layer. We may need to do something in the select top k tokens code latter but don't worry about that just yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if I'm going down the right path so I'm just committing what I've got so far for a "midway" review.