Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls from OverrideConfiguration to parentConfiguration cause unnecessary overhead. #201

Closed
marcus-talbot42 opened this issue Apr 4, 2024 · 0 comments · Fixed by #202
Closed
Assignees

Comments

@marcus-talbot42
Copy link
Contributor

Much like the OverrideField, calls to the parentConfiguration cause unnecessary overhead, due to the depth of the call tree. As the result of those calls are not cached in a field, in contrast to the OverrideField where every value was cached, the overhead is potentially higher.

The solution would be to introduce fields in the OverrideConfiguration for every field that is retrieved from the parentConfiguration, and fill those fields on initialisation of the OverrideConfiguration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant