Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AG Review #4

Open
audreyegill opened this issue Sep 28, 2018 · 0 comments
Open

AG Review #4

audreyegill opened this issue Sep 28, 2018 · 0 comments

Comments

@audreyegill
Copy link

Excellent problem description
Problem description, pseudo code, and overall document well organized and easy to read
Typo on tests section? "...for indexes on read1, read2..." should be "indexes on index1, index2..." ?
Clear description of output, meets assignment criteria

I think storing the information in two dictionaries and then comparing those is more computationally intensive than it needs to be. You could could read all four files and then compare the records from all four files directly. But your overall process accomplishes what needs to be accomplished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant