Peer Review

[gartician]

Deduper Peer Review for Maddy
- Does the proposed algorithm make sense to you? Can you follow the logic?
The proposed algorithm makes sense and is logically organized, and the unit test is simple and effective.
- Does the algorithm do everything it's supposed to do? (see part 1)
A sliding window of 50 may be too low because Jason pointed out that duplicates may be really far away. I liked how considered the I, D, and N options for the CIGAR string.
- Are proposed functions reasonable? Are they "standalone" pieces of code?
The proposed functions are standalone and are understandable. Including the extra two columns of adjusted position and UMI’s were good ideas.
Further comments: I’m not really familiar with a sliding window approach, and wonder if it’s controlled by a for or while loop?