Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Review #2

Open
adoe21 opened this issue Oct 24, 2018 · 0 comments
Open

Peer Review #2

adoe21 opened this issue Oct 24, 2018 · 0 comments

Comments

@adoe21
Copy link

adoe21 commented Oct 24, 2018

Pseudocode:
-Good unit tests
-Would recommend larger sliding window
-My concern with the sliding window is that at some point you will pop off reads that had a PCR duplicate lower in the file, so that when your sliding window reaches that read, it will not recognize it as a PCR duplicate.
-I'm not sure how big your sliding window would have to be to account for this, and you're saving a lot into the window, so you can't use a window the size of a chromosome.
-Good functions to manipulate your numpy array
-Good functions for determining PCR duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant