✨️ api: return 200 when certification is a V3CertificationAttestation

Co-authored-by: Geoffroy Begouaussel <[email protected]>

Author: AndreiaPena

api/src/certification/results/application/certification-attestation-controller.js

@@ -1,5 +1,6 @@
 import dayjs from 'dayjs';
 
+import { V3CertificationAttestation } from '../domain/models/V3CertificationAttestation.js';
 import { usecases } from '../domain/usecases/index.js';
 import * as certificationAttestationPdf from '../infrastructure/utils/pdf/certification-attestation-pdf.js';
 
@@ -14,6 +15,10 @@ const getPDFAttestation = async function (request, h, dependencies = { certifica
     certificationCourseId,
   });
 
+  if (attestation instanceof V3CertificationAttestation) {
+    return h.response().code(200);
+  }
+
   const { buffer, fileName } = await dependencies.certificationAttestationPdf.getCertificationAttestationsPdfBuffer({
     certificates: [attestation],
     isFrenchDomainExtension,
@@ -36,6 +41,11 @@ const getCertificationPDFAttestationsForSession = async function (
   const attestations = await usecases.getCertificationAttestationsForSession({
     sessionId,
   });
+
+  if (attestations.every((attestation) => attestation instanceof V3CertificationAttestation)) {
+    return h.response().code(200);
+  }
+
   const i18n = request.i18n;
 
   const { buffer } = await dependencies.certificationAttestationPdf.getCertificationAttestationsPdfBuffer({

api/tests/certification/evaluation/acceptance/application/certification-attestation-route_test.js

@@ -2,8 +2,10 @@ import { readFile } from 'node:fs/promises';
 import * as url from 'node:url';
 
 import { generateCertificateVerificationCode } from '../../../../../src/certification/evaluation/domain/services/verify-certificate-code-service.js';
+import { SESSIONS_VERSIONS } from '../../../../../src/certification/shared/domain/models/SessionVersion.js';
 import { Assessment } from '../../../../../src/shared/domain/models/index.js';
 import { AssessmentResult, Membership } from '../../../../../src/shared/domain/models/index.js';
+import { featureToggles } from '../../../../../src/shared/infrastructure/feature-toggles/index.js';
 import {
   createServer,
   databaseBuilder,
@@ -112,26 +114,79 @@ describe('Certification | Results | Acceptance | Application | Routes | certific
 
   describe('GET /api/attestation/{certificationCourseId}', function () {
     context('when user own the certification', function () {
-      it('should return 200 HTTP status code and the certification', async function () {
-        // given
-        const userId = databaseBuilder.factory.buildUser().id;
-        await _buildDatabaseForV2Certification({ userId, certificationCourseId: 1234 });
-        await databaseBuilder.commit();
-
-        const server = await createServer();
-
-        // when
-        const response = await server.inject({
-          method: 'GET',
-          url: '/api/attestation/1234?isFrenchDomainExtension=true&lang=fr',
-          headers: generateAuthenticatedUserRequestHeaders({ userId }),
+      context('when session version is V3', function () {
+        context('when isV3CertificationAttestationEnabled feature toggle is truthy', function () {
+          it('should return 200 HTTP status code and the certification', async function () {
+            // given
+            await featureToggles.set('isV3CertificationAttestationEnabled', true);
+            const userId = databaseBuilder.factory.buildUser().id;
+
+            const session = databaseBuilder.factory.buildSession({
+              id: 123,
+              publishedAt: new Date('2018-12-01T01:02:03Z'),
+              version: SESSIONS_VERSIONS.V3,
+            });
+            const certificationCourse = databaseBuilder.factory.buildCertificationCourse({
+              id: 1234,
+              sessionId: session.id,
+              userId,
+              isPublished: true,
+              verificationCode: await generateCertificateVerificationCode(),
+            });
+            const assessment = databaseBuilder.factory.buildAssessment({
+              userId,
+              certificationCourseId: certificationCourse.id,
+              type: Assessment.types.CERTIFICATION,
+              state: Assessment.states.COMPLETED,
+            });
+            databaseBuilder.factory.buildAssessmentResult.last({
+              certificationCourseId: certificationCourse.id,
+              assessmentId: assessment.id,
+              level: 1,
+              pixScore: 23,
+              emitter: 'PIX-ALGO',
+              status: AssessmentResult.status.VALIDATED,
+            });
+
+            await databaseBuilder.commit();
+
+            const server = await createServer();
+
+            // when
+            const response = await server.inject({
+              method: 'GET',
+              url: `/api/attestation/${certificationCourse.id}?isFrenchDomainExtension=true&lang=fr`,
+              headers: generateAuthenticatedUserRequestHeaders({ userId }),
+            });
+
+            // then
+            expect(response.statusCode).to.equal(200);
+          });
         });
+      });
+
+      context('when session version is V2', function () {
+        it('should return 200 HTTP status code and the certification', async function () {
+          // given
+          const userId = databaseBuilder.factory.buildUser().id;
+          await _buildDatabaseForV2Certification({ userId, certificationCourseId: 1234 });
+          await databaseBuilder.commit();
+
+          const server = await createServer();
 
-        // then
-        expect(response.statusCode).to.equal(200);
-        expect(response.headers['content-type']).to.equal('application/pdf');
-        expect(response.headers['content-disposition']).to.include('filename=attestation-pix');
-        expect(response.file).not.to.be.null;
+          // when
+          const response = await server.inject({
+            method: 'GET',
+            url: '/api/attestation/1234?isFrenchDomainExtension=true&lang=fr',
+            headers: generateAuthenticatedUserRequestHeaders({ userId }),
+          });
+
+          // then
+          expect(response.statusCode).to.equal(200);
+          expect(response.headers['content-type']).to.equal('application/pdf');
+          expect(response.headers['content-disposition']).to.include('filename=attestation-pix');
+          expect(response.file).not.to.be.null;
+        });
       });
     });
   });