Skip to content

Commit 43057d1

Browse files
Fix CTL grouping
See 0xPolygonZero#1582
1 parent d48ce9c commit 43057d1

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

starky/src/cross_table_lookup.rs

+7-7
Original file line numberDiff line numberDiff line change
@@ -396,14 +396,14 @@ fn ctl_helper_zs_cols<F: Field, const N: usize>(
396396
challenge: GrandProductChallenge<F>,
397397
constraint_degree: usize,
398398
) -> Vec<(usize, Vec<PolynomialValues<F>>)> {
399-
let grouped_lookups = looking_tables.iter().group_by(|a| a.table);
400-
401-
grouped_lookups
399+
looking_tables
400+
.iter()
401+
.map(|a| (a.table, (&a.columns[..], &a.filter)))
402+
.into_group_map()
402403
.into_iter()
403-
.map(|(table, group)| {
404-
let columns_filters = group
405-
.map(|table| (&table.columns[..], &table.filter))
406-
.collect::<Vec<(&[Column<F>], &Filter<F>)>>();
404+
// We sort for determinism:
405+
.sorted_by_key(|(table, _)| *table)
406+
.map(|(table, columns_filters)| {
407407
(
408408
table,
409409
partial_sums(

0 commit comments

Comments
 (0)