Skip to content

Commit 13f31f6

Browse files
akpm00sfrothwell
authored andcommitted
powerpc-64s-implement-arch-specific-hardlockup-watchdog-checkpatch-fixes
WARNING: line over 80 characters torvalds#97: FILE: arch/powerpc/include/asm/smp.h:59: +extern int smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us); WARNING: line over 80 characters torvalds#119: FILE: arch/powerpc/kernel/exceptions-64s.S:1276: +#if defined(CONFIG_HARDLOCKUP_DETECTOR) && defined(CONFIG_HAVE_HARDLOCKUP_DETECTOR_ARCH) ERROR: do not initialise statics to 0 torvalds#317: FILE: arch/powerpc/kernel/watchdog.c:62: +static unsigned long __wd_smp_lock = 0; WARNING: memory barrier without comment torvalds#554: FILE: arch/powerpc/kernel/watchdog.c:299: + smp_wmb(); WARNING: Prefer pr_warn(... to pr_warning(... torvalds#617: FILE: arch/powerpc/kernel/watchdog.c:362: + pr_warning("Watchdog could not be initialized"); total: 1 errors, 4 warnings, 543 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/powerpc-64s-implement-arch-specific-hardlockup-watchdog.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Nicholas Piggin <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 93abc74 commit 13f31f6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/powerpc/kernel/watchdog.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ static DEFINE_PER_CPU(u64, wd_timer_tb);
5959
* This will work best with NMI IPIs for crash code so the stuck CPUs
6060
* can be pulled out to get their backtraces.
6161
*/
62-
static unsigned long __wd_smp_lock = 0;
62+
static unsigned long __wd_smp_lock;
6363
static cpumask_t wd_smp_cpus_pending;
6464
static cpumask_t wd_smp_cpus_stuck;
6565
static u64 wd_smp_last_reset_tb;
@@ -359,7 +359,7 @@ static int __init powerpc_watchdog_init(void)
359359
err = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "powerpc/watchdog:online",
360360
start_wd_on_cpu, stop_wd_on_cpu);
361361
if (err < 0)
362-
pr_warning("Watchdog could not be initialized");
362+
pr_warn("Watchdog could not be initialized");
363363

364364
return 0;
365365
}

0 commit comments

Comments
 (0)