Skip to content

Commit 0b38c53

Browse files
akpm00sfrothwell
authored andcommitted
mm-prepare-page_referenced-and-page_idle-to-new-thp-refcounting-checkpatch-fixes
ERROR: code indent should use tabs where possible torvalds#171: FILE: mm/page_idle.c:75: + if (!pmd_present(*pmd))$ WARNING: please, no spaces at the start of a line torvalds#171: FILE: mm/page_idle.c:75: + if (!pmd_present(*pmd))$ WARNING: Missing a blank line after declarations torvalds#194: FILE: mm/page_idle.c:93: + pmd_t pmde = *pmd; + barrier(); WARNING: Missing a blank line after declarations torvalds#304: FILE: mm/rmap.c:867: + pmd_t pmde = *pmd; + barrier(); total: 1 errors, 3 warnings, 327 lines checked NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile ./patches/mm-prepare-page_referenced-and-page_idle-to-new-thp-refcounting.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: "Kirill A. Shutemov" <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 3669c17 commit 0b38c53

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

mm/page_idle.c

+2-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ static int page_idle_clear_pte_refs_one(struct page *page,
7272

7373
if (pmd_trans_huge(*pmd)) {
7474
ptl = pmd_lock(mm, pmd);
75-
if (!pmd_present(*pmd))
75+
if (!pmd_present(*pmd))
7676
goto unlock_pmd;
7777
if (unlikely(!pmd_trans_huge(*pmd))) {
7878
spin_unlock(ptl);
@@ -90,6 +90,7 @@ static int page_idle_clear_pte_refs_one(struct page *page,
9090
return SWAP_AGAIN;
9191
} else {
9292
pmd_t pmde = *pmd;
93+
9394
barrier();
9495
if (!pmd_present(pmde) || pmd_trans_huge(pmde))
9596
return SWAP_AGAIN;

mm/rmap.c

+1
Original file line numberDiff line numberDiff line change
@@ -866,6 +866,7 @@ static int page_referenced_one(struct page *page, struct vm_area_struct *vma,
866866
return ret;
867867
} else {
868868
pmd_t pmde = *pmd;
869+
869870
barrier();
870871
if (!pmd_present(pmde) || pmd_trans_huge(pmde))
871872
return SWAP_AGAIN;

0 commit comments

Comments
 (0)