Skip to content

Commit 07af5da

Browse files
akpm00sfrothwell
authored andcommitted
ipc-sem-rework-task-wakeups-checkpatch-fixes
WARNING: line over 80 characters torvalds#241: FILE: ipc/sem.c:815: + semop_completed |= wake_const_ops(sma, num, wake_q); WARNING: line over 80 characters torvalds#250: FILE: ipc/sem.c:826: + semop_completed |= wake_const_ops(sma, i, wake_q); WARNING: line over 80 characters torvalds#282: FILE: ipc/sem.c:857: +static int update_queue(struct sem_array *sma, int semnum, struct wake_q_head *wake_q) WARNING: line over 80 characters torvalds#344: FILE: ipc/sem.c:973: + sops[i].sem_num, wake_q); WARNING: Missing a blank line after declarations torvalds#405: FILE: ipc/sem.c:1242: + int err, val; + WAKE_Q(wake_q); WARNING: line over 80 characters torvalds#570: FILE: ipc/sem.c:1920: + * We _do_ care, nonetheless, about being awoken by a signal or spuriously. total: 0 errors, 6 warnings, 567 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/ipc-sem-rework-task-wakeups.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Davidlohr Bueso <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 15f900e commit 07af5da

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

ipc/sem.c

+5-4
Original file line numberDiff line numberDiff line change
@@ -1917,10 +1917,11 @@ SYSCALL_DEFINE4(semtimedop, int, semid, struct sembuf __user *, tsops,
19171917
* fastpath: the semop has completed, either successfully or not, from
19181918
* the syscall pov, is quite irrelevant to us at this point; we're done.
19191919
*
1920-
* We _do_ care, nonetheless, about being awoken by a signal or spuriously.
1921-
* The queue.status is checked again in the slowpath (aka after taking
1922-
* sem_lock), such that we can detect scenarios where we were awakened
1923-
* externally, during the window between wake_q_add() and wake_up_q().
1920+
* We _do_ care, nonetheless, about being awoken by a signal or
1921+
* spuriously. The queue.status is checked again in the slowpath (aka
1922+
* after taking sem_lock), such that we can detect scenarios where we
1923+
* were awakened externally, during the window between wake_q_add() and
1924+
* wake_up_q().
19241925
*/
19251926
error = READ_ONCE(queue.status);
19261927
if (error != -EINTR) {

0 commit comments

Comments
 (0)